You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2015/08/14 12:21:38 UTC
Review Request 37475: Fixed a wrong comparison.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37475/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
-------
Compiling with GCC 5.1.1 fails, because of a comparison between `int` and `unsigned int` in `scheduler/scheduler.cpp`. This patch fixes the comparison.
Diffs
-----
src/scheduler/scheduler.cpp cf433ff8ec8768e1f4409a1fa2fd5ef6fbebc491
Diff: https://reviews.apache.org/r/37475/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 37475: Fixed a wrong comparison.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37475/#review95407
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Aug. 14, 2015, 10:21 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37475/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 10:21 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Compiling with GCC 5.1.1 fails, because of a comparison between `int` and `unsigned int` in `scheduler/scheduler.cpp`. This patch fixes the comparison.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp cf433ff8ec8768e1f4409a1fa2fd5ef6fbebc491
>
> Diff: https://reviews.apache.org/r/37475/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 37475: Fixed a wrong comparison.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37475/#review95412
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37475]
All tests passed.
- Mesos ReviewBot
On Aug. 14, 2015, 10:21 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37475/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 10:21 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Compiling with GCC 5.1.1 fails, because of a comparison between `int` and `unsigned int` in `scheduler/scheduler.cpp`. This patch fixes the comparison.
>
>
> Diffs
> -----
>
> src/scheduler/scheduler.cpp cf433ff8ec8768e1f4409a1fa2fd5ef6fbebc491
>
> Diff: https://reviews.apache.org/r/37475/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>