You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by srikanteswartalluri <gi...@git.apache.org> on 2015/04/13 12:36:23 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...
GitHub user srikanteswartalluri opened a pull request:
https://github.com/apache/cloudstack/pull/158
CLOUDSTACK-8379:add support to marvin to enable deployed zone based on t...
...he value provided in config file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srikanteswartalluri/cloudstack enablezone
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #158
----
commit 9dbd28e5fe855a809700ec6246b204e7eb0f7c02
Author: SrikanteswaraRao Talluri <ta...@apache.org>
Date: 2015-04-13T10:34:19Z
CLOUDSTACK-8379:add support to marvin to enable deployed zone based on the value provided in config file
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...
Posted by srikanteswartalluri <gi...@git.apache.org>.
Github user srikanteswartalluri closed the pull request at:
https://github.com/apache/cloudstack/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-117979550
@gauravaradhye can you review this ? @srikanteswartalluri looks like Travis failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...
Posted by srikanteswartalluri <gi...@git.apache.org>.
Github user srikanteswartalluri commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-129546119
Folks,
i am closing the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-129040590
@srikanteswartalluri Any update on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-129368171
-1
Without changes it works fine, because if we don't specify the "enabled" attribute for the zone in the config file, it will enable the zone by default. Even if the zone has the attribute "enabled" without any value , then also we enable the zone. It anything other than "true" then only we won't enable the zone.
With @srikanteswartalluri changes this functionality will be broken because he is converting the "None" to string in "getattr" method. So the following line will always have some string:
enabled = enabled if enabled else 'true'
and if the zone object does not have the "enabled" attribute we are not calling the enableZone which is not expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-120371884
I don't see that the travis failures are related to this code but the change is not so significant that push through makes sense. Would be nice to have quick iterations on these kinds of refactorings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-127891937
enabled = enabled if enabled else 'true'
will set enable to true if enable is false or None which is unexpected,
ideally enable should be false if it is false in config file else true
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8379:add support to marvin to ...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/158#discussion_r34343974
--- Diff: tools/marvin/marvin/deployDataCenter.py ---
@@ -790,8 +790,13 @@ def createZones(self, zones):
self.createPrimaryStorages(zone.primaryStorages,
zoneId,
)
- enabled = getattr(zone, 'enabled', 'True')
- if enabled == 'True' or enabled is None:
+
+ #get the variable from config file whether to enable zone or not
+ #If "enabled" tag is not found in config file, enable the zone otherwise
+ #act as mentioned in the config file
+ enabled = str(getattr(zone, 'enabled', None))
+ enabled = enabled if enabled else 'true'
+ if enabled.lower() == 'true':
--- End diff --
should work but why not make a str('boolean') a real bool?
if enabled.lower == true:
enable = True
else:
enable = False
if enable:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---