You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by inbar stolberg <no...@github.com> on 2014/10/23 09:45:59 UTC
[jclouds] cinder availability zones api + list call implemented
(#581)
cinder availability zones api + list call implemented
fro PR https://github.com/jclouds/jclouds/pull/560
You can merge this Pull Request by running:
git pull https://github.com/inbarsto/cloudband-jclouds cinderAZMaster2
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/581
-- Commit Summary --
* cinder availability zones api + list call implemented
-- File Changes --
M apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/CinderApi.java (9)
A apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/domain/zonescoped/AvailabilityZone.java (112)
A apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/domain/zonescoped/ZoneState.java (101)
A apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/extensions/AvailabilityZoneApi.java (56)
A apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/extensions/ExtensionNamespaces.java (33)
A apis/openstack-cinder/src/test/java/org/jclouds/openstack/cinder/v1/features/AvailabilityZoneApiExpectTest.java (72)
A apis/openstack-cinder/src/test/java/org/jclouds/openstack/cinder/v1/features/AvailabilityZoneApiLiveTest.java (57)
A apis/openstack-cinder/src/test/resources/availability_zones_list.json (8)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/581.patch
https://github.com/jclouds/jclouds/pull/581.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by Andrew Phillips <no...@github.com>.
> +import static org.testng.Assert.assertTrue;
> +
> +@Test(groups = "live", testName = "AvailabilityZoneApiLiveTest", singleThreaded = true)
> +public class AvailabilityZoneApiLiveTest extends BaseCinderApiLiveTest {
> +
> + private AvailabilityZoneApi availabilityZoneApi;
> +
> + public AvailabilityZoneApiLiveTest() {
> + super();
> + provider = "openstack-cinder";
> + }
> +
> + @BeforeClass(groups = {"integration", "live"})
> + public void setupContext() {
> + super.setup();
> + String zone = Iterables.getFirst(api.getConfiguredZones(), "regionOne");
@inbarsto Just noticed: should this be `api.getConfiguredRegions()`? If so, I'll fix in a quick follow-up commit.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581/files#r19324015
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1835](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1835/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60286599
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1830](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1830/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60206362
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1324](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1324/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60277431
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by inbar stolberg <no...@github.com>.
thanks @demobox :)
and @jdaggett and @adriancole and god knows who else was on the original PR :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60347554
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by Jeremy Daggett <no...@github.com>.
@inbarsto There is a Checkstyle failure on the import of the `ZoneToEndpoint` class. Also, I just noticed that we should move the `AvailabilityZone` and `ZoneState` classes to the `org.jclouds.openstack.cinder.v1.domain` package and delete the `org.jclouds.openstack.cinder.v1.domain.zonescoped` package.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60272460
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by Andrew Phillips <no...@github.com>.
Merged to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=1205010cfa40363c403aa2c1b88271774b3f1d04).
Uff. We got there!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60347245
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1318](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1318/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60204817
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by inbar stolberg <no...@github.com>.
Yeah. Seems legit :)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60357081
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by inbar stolberg <no...@github.com>.
done
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60273396
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by inbar stolberg <no...@github.com>.
i saw, fixed
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60272655
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #234](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/234/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60272695
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #235](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/235/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60273527
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1323](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1323/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60276112
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #229](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/229/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60203505
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #1836](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1836/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60297377
Re: [jclouds] cinder availability zones api + list call implemented
(#581)
Posted by Andrew Phillips <no...@github.com>.
> Yeah. Seems legit :)
Follow-up committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=6cb1558424055972a6e04539b88cda29680fc31c)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/581#issuecomment-60358107