[GitHub] [flink] zjuwangg commented on a diff in pull request #20094: [hotfix][doc] fix code mismatch in filesystem.md

[GitBox <gi...@apache.org>]

zjuwangg commented on code in PR #20094:
URL: https://github.com/apache/flink/pull/20094#discussion_r912603500


##########
docs/content/docs/connectors/datastream/filesystem.md:
##########
@@ -315,9 +315,9 @@ final FileSink<String> sink = FileSink
     .forRowFormat(new Path(outputPath), new SimpleStringEncoder<String>("UTF-8"))
     .withRollingPolicy(
         DefaultRollingPolicy.builder()
-            .withRolloverInterval(Duration.ofSeconds(10))
-            .withInactivityInterval(Duration.ofSeconds(10))
-            .withMaxPartSize(MemorySize.ofMebiBytes(1))
+            .withRolloverInterval(Duration.ofMinutes(15))
+            .withInactivityInterval(Duration.ofMinutes(5))
+            .withMaxPartSize(MemorySize.ofMebiBytes(1024))

Review Comment:
   Oh yes. If you look this article line 357, 
   ```
   This example creates a simple sink that assigns records to the default one hour time buckets. It also specifies a rolling policy that rolls the in-progress part file on any of the following 3 conditions:
    - It contains at least 15 minutes worth of data
    - It hasn't received new records for the last 5 minutes	
    - The file size has reached 1 GB (after writing the last record)	 
   ```
    you will find the description is not matched with the code arguments here.
   Thx for your review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org