You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Adam Winer (JIRA)" <de...@myfaces.apache.org> on 2007/06/28 00:29:26 UTC

[jira] Created: (TRINIDAD-78) Responses can be generated in XHTML format when included .jspx files don't specify contentTypew

Responses can be generated in XHTML format when included .jspx files don't specify contentTypew
-----------------------------------------------------------------------------------------------

                 Key: TRINIDAD-78
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-78
             Project: MyFaces Trinidad
          Issue Type: Bug
    Affects Versions: 1.0.1-core
            Reporter: Adam Winer
            Assignee: Adam Winer


In a .jspx, the default contentType is text/xml, so this results
in a call to setContentType("text/xml"), and we use XHTML
as a result.  That's fine when it's the top-level page that has
made this mistake, but content types are supposed to be
ignored in included pages.  The servlet engine is smart enough
to ignore the calls, but our DispatchServletResponse class
isn't!  So, if you <jsp:include> a .jspx page, and that .jspx
page doesn't specify a contentType, even though the parent
page was text/html, Trinidad can get confused

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TRINIDAD-78) Responses can be generated in XHTML format when included .jspx files don't specify contentTypew

Posted by "Adam Winer (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TRINIDAD-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Winer resolved TRINIDAD-78.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.2-core

Fixed - we now don't bother stashing off the results of calls to setContentType() when they come from inside an include.

> Responses can be generated in XHTML format when included .jspx files don't specify contentTypew
> -----------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-78
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-78
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.0.1-core
>            Reporter: Adam Winer
>            Assignee: Adam Winer
>             Fix For: 1.0.2-core
>
>
> In a .jspx, the default contentType is text/xml, so this results
> in a call to setContentType("text/xml"), and we use XHTML
> as a result.  That's fine when it's the top-level page that has
> made this mistake, but content types are supposed to be
> ignored in included pages.  The servlet engine is smart enough
> to ignore the calls, but our DispatchServletResponse class
> isn't!  So, if you <jsp:include> a .jspx page, and that .jspx
> page doesn't specify a contentType, even though the parent
> page was text/html, Trinidad can get confused

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.