You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/10/13 16:42:49 UTC
[GitHub] [incubator-hugegraph-commons] imbajin opened a new pull request, #108: feat(apache): support check license header with RAT
imbajin opened a new pull request, #108:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/108
use `apache-rat:check` to see the report
and fix current license problems
TODO: we should add & use apache-rat plugin in other repos later
BTW, we'd reuse such configs better (rather than copy them in each repo)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin commented on a diff in pull request #108: feat(apache): support check license header with RAT
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #108:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/108#discussion_r997132253
##########
pom.xml:
##########
@@ -164,6 +180,43 @@
</execution>
</executions>
</plugin>
+ <!-- Apache RAT for license check -->
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
Review Comment:
nope, consider add it in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin commented on a diff in pull request #108: feat(apache): support check license header with RAT
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #108:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/108#discussion_r997132253
##########
pom.xml:
##########
@@ -164,6 +180,43 @@
</execution>
</executions>
</plugin>
+ <!-- Apache RAT for license check -->
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
Review Comment:
nope, consider add it in a separate PR (need test it in CI, currently it can't return bool value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin commented on a diff in pull request #108: feat(apache): support check license header with RAT
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #108:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/108#discussion_r997132253
##########
pom.xml:
##########
@@ -164,6 +180,43 @@
</execution>
</executions>
</plugin>
+ <!-- Apache RAT for license check -->
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
Review Comment:
nope, consider add it in a separate PR (need test it in CI, currently it can't return bool value)
PS: use a trick way to show it in CI (enhance it later..)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin commented on a diff in pull request #108: feat(apache): support check license header with RAT
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #108:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/108#discussion_r997132705
##########
hugegraph-common/src/test/java/org/apache/hugegraph/unit/concurrent/BarrierEventTest.java:
##########
@@ -13,7 +32,7 @@
public class BarrierEventTest {
- private static int WAIT_THREADS_COUNT = 10;
+ private static final int WAIT_THREADS_COUNT = 10;
Review Comment:
ok, little change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] javeme commented on a diff in pull request #108: feat(apache): support check license header with RAT
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #108:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/108#discussion_r996234220
##########
pom.xml:
##########
@@ -164,6 +180,43 @@
</execution>
</executions>
</plugin>
+ <!-- Apache RAT for license check -->
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
Review Comment:
does it enable auto check in CI?
##########
hugegraph-common/src/test/java/org/apache/hugegraph/unit/concurrent/BarrierEventTest.java:
##########
@@ -13,7 +32,7 @@
public class BarrierEventTest {
- private static int WAIT_THREADS_COUNT = 10;
+ private static final int WAIT_THREADS_COUNT = 10;
Review Comment:
Separate from this PR? since this pr can be used as a guide for other repos.
##########
hugegraph-common/pom.xml:
##########
@@ -11,7 +27,7 @@
</parent>
<artifactId>hugegraph-common</artifactId>
- <name>${artifactId}</name>
+ <name>${project.artifactId}</name>
Review Comment:
Separate from this PR? since this pr can be used as a guide for other repos.
##########
pom.xml:
##########
@@ -18,9 +34,9 @@
</description>
<parent>
- <groupId>org.sonatype.oss</groupId>
- <artifactId>oss-parent</artifactId>
- <version>7</version>
+ <groupId>org.apache</groupId>
Review Comment:
Separate from this PR? since this pr can be used as a guide for other repos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] codecov[bot] commented on pull request #108: feat(apache): support check license header with RAT
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #108:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/108#issuecomment-1277904479
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-commons/pull/108?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#108](https://codecov.io/gh/apache/incubator-hugegraph-commons/pull/108?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c26f77) into [master](https://codecov.io/gh/apache/incubator-hugegraph-commons/commit/e85ab38c6b8bebfe2734df37ef06d8978fbe3b71?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e85ab38) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #108 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 65 65
=========================================
Files 9 9
Lines 263 263
Branches 22 22
=========================================
Hits 245 245
Misses 8 8
Partials 10 10
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin merged pull request #108: feat(apache): support check license header with RAT
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #108:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin commented on a diff in pull request #108: feat(apache): support check license header with RAT
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #108:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/108#discussion_r997132253
##########
pom.xml:
##########
@@ -164,6 +180,43 @@
</execution>
</executions>
</plugin>
+ <!-- Apache RAT for license check -->
+ <plugin>
+ <groupId>org.apache.rat</groupId>
+ <artifactId>apache-rat-plugin</artifactId>
Review Comment:
nope, consider add it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin commented on a diff in pull request #108: feat(apache): support check license header with RAT
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #108:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/108#discussion_r999442509
##########
hugegraph-common/pom.xml:
##########
@@ -11,7 +27,7 @@
</parent>
<artifactId>hugegraph-common</artifactId>
- <name>${artifactId}</name>
+ <name>${project.artifactId}</name>
Review Comment:
separated it already, although other repos should also update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org