[Bug 7445] New: The default mbox separator regex is dangerously pedantic

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7445

            Bug ID: 7445
           Summary: The default mbox separator regex is dangerously
                    pedantic
           Product: Spamassassin
           Version: 3.4.1
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Libraries
          Assignee: dev@spamassassin.apache.org
          Reporter: rwmaillists@googlemail.com
  Target Milestone: Undefined

Created attachment 5456
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5456&action=edit
patch to allow  single spacing

In the user list thread "sa-learn won't read db created via MSTOR" sa-learn
found no emails in an mbox file because the separator looked like this:

From - Sat Jul 8 01:02:28 2017

The important thing is the single space before the 8. The default regex looks
for " .\d " so a single digit date has to be justified with either an extra
space or a leading 0. 

What's particularly bad is that it's not consistent. The OP was lucky that it
happened on the 8th, a couple of days later and it would have appeared to work.
The worst case is where the dates are mixed, in which case many of the emails
will get concatenated.  Changing "." to ".?" fixes the problem - see patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7445] The default mbox separator regex is dangerously pedantic

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7445

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |blocker
   Target Milestone|Undefined                   |3.4.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7445] The default mbox separator regex is dangerously pedantic

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7445

Bill Cole <bi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
                 CC|                            |billcole@apache.org

--- Comment #1 from Bill Cole <bi...@apache.org> ---
This change looks good to me. Makes padding of single-digit dates in mbox
separator lines optional. 

I believe this qualifies as trivial under this criteria on the DevelopmentMode
page:


    very simple, non-controversial, and absolutely safe bug fixes (i.e.:
removing repetitive my() enclosing sections)

Committed in r1840072

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7445] The default mbox separator regex is dangerously pedantic

[bu...@bugzilla.spamassassin.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7445

Karsten Bräckelmann <gu...@rudersport.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Security                    |Libraries
           Assignee|security@spamassassin.apach |dev@spamassassin.apache.org
                   |e.org                       |
              Group|security                    |

-- 
You are receiving this mail because:
You are the assignee for the bug.