You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/05/27 09:26:00 UTC
[GitHub] [servicecomb-java-chassis] demonbug opened a new pull request, #3009: [SCB-2533] encode invocation context before add to http header
demonbug opened a new pull request, #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009
fix issus #3008
add writeUnicodeValueAsString to JsonUtils to support unicode encoding
encode invocation context before add to http header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#discussion_r885130237
##########
foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/JsonUtilsTest.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.foundation.common.utils;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.type.TypeReference;
+import junit.framework.TestCase;
+import org.apache.commons.lang.StringUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.HashMap;
+import java.util.Map;
Review Comment:
Use junit5 for new test cases, and I'd prefer PR for master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#discussion_r885127883
##########
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/RestClientInvocation.java:
##########
@@ -274,7 +274,7 @@ protected void fail(ConnectionBase connection, Throwable e) {
protected void setCseContext() {
try {
- String cseContext = JsonUtils.writeValueAsString(invocation.getContext());
+ String cseContext = JsonUtils.writeUnicodeValueAsString(invocation.getContext());
Review Comment:
Can you add some unit test case for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] demonbug commented on a diff in pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
demonbug commented on code in PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#discussion_r891241618
##########
foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/JsonUtilsTest.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.foundation.common.utils;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.type.TypeReference;
+import junit.framework.TestCase;
+import org.apache.commons.lang.StringUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.HashMap;
+import java.util.Map;
Review Comment:
the lastest NUWA is still using branch 1.3.x, and this branch has not import junit5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#issuecomment-1149424852
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3009](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6fd7af6) into [1.3.x](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/0ebad34d7e146d0a7482cace62ee78dddfde3649?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0ebad34) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## 1.3.x #3009 +/- ##
============================================
+ Coverage 82.99% 83.00% +0.01%
Complexity 746 746
============================================
Files 1233 1233
Lines 33082 33084 +2
Branches 3001 3001
============================================
+ Hits 27455 27460 +5
+ Misses 4441 4439 -2
+ Partials 1186 1185 -1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...servicecomb/foundation/common/utils/JsonUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL3V0aWxzL0pzb25VdGlscy5qYXZh) | `66.66% <100.00%> (+5.55%)` | :arrow_up: |
| [...b/loadbalance/filter/IsolationDiscoveryFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1sb2FkYmFsYW5jZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvbG9hZGJhbGFuY2UvZmlsdGVyL0lzb2xhdGlvbkRpc2NvdmVyeUZpbHRlci5qYXZh) | `87.01% <100.00%> (-0.17%)` | :arrow_down: |
| [...ansport/rest/client/http/RestClientInvocation.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtcmVzdC90cmFuc3BvcnQtcmVzdC1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3RyYW5zcG9ydC9yZXN0L2NsaWVudC9odHRwL1Jlc3RDbGllbnRJbnZvY2F0aW9uLmphdmE=) | `94.89% <100.00%> (+1.45%)` | :arrow_up: |
| [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZS1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `61.88% <0.00%> (-0.40%)` | :arrow_down: |
| [...in/java/org/apache/servicecomb/core/SCBEngine.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9TQ0JFbmdpbmUuamF2YQ==) | `83.15% <0.00%> (+1.57%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d3fd70c...6fd7af6](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/3009?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#discussion_r884359193
##########
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/RestClientInvocation.java:
##########
@@ -274,7 +274,7 @@ protected void fail(ConnectionBase connection, Throwable e) {
protected void setCseContext() {
try {
- String cseContext = JsonUtils.writeValueAsString(invocation.getContext());
+ String cseContext = JsonUtils.writeUnicodeValueAsString(invocation.getContext());
Review Comment:
Is this compatible with old versions? e.g. new consumer invoke an older version provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#discussion_r885130237
##########
foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/JsonUtilsTest.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.foundation.common.utils;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.type.TypeReference;
+import junit.framework.TestCase;
+import org.apache.commons.lang.StringUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.HashMap;
+import java.util.Map;
Review Comment:
Use junit5 for test cases, and I'd prefer PR for master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#discussion_r885127883
##########
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/RestClientInvocation.java:
##########
@@ -274,7 +274,7 @@ protected void fail(ConnectionBase connection, Throwable e) {
protected void setCseContext() {
try {
- String cseContext = JsonUtils.writeValueAsString(invocation.getContext());
+ String cseContext = JsonUtils.writeUnicodeValueAsString(invocation.getContext());
Review Comment:
Can you add some unit test case for this and create a PR for master? I'd prefer not merge this for 1.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] demonbug commented on a diff in pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
demonbug commented on code in PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#discussion_r891885187
##########
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/RestClientInvocation.java:
##########
@@ -274,7 +274,7 @@ protected void fail(ConnectionBase connection, Throwable e) {
protected void setCseContext() {
try {
- String cseContext = JsonUtils.writeValueAsString(invocation.getContext());
+ String cseContext = JsonUtils.writeUnicodeValueAsString(invocation.getContext());
Review Comment:
ok, i added 2 testcase in TestRestClientInvocation.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] demonbug closed pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
demonbug closed pull request #3009: [SCB-2533] encode invocation context before add to http header
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] Shoothzj commented on a diff in pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on code in PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#discussion_r891300844
##########
foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/JsonUtilsTest.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.foundation.common.utils;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.core.type.TypeReference;
+import junit.framework.TestCase;
+import org.apache.commons.lang.StringUtils;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.HashMap;
+import java.util.Map;
Review Comment:
@demonbug @liubao68 I suggest we can contribute it to master first, then port it to 1.3.X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] demonbug commented on pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
demonbug commented on PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#issuecomment-1149518857
> Apache commons-lang3 also have `StringEscapeUtils`, why we need `commons-text`?
StringEscapeUtils was deprecated in commons-lang3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] demonbug commented on a diff in pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
demonbug commented on code in PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#discussion_r884388875
##########
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/RestClientInvocation.java:
##########
@@ -274,7 +274,7 @@ protected void fail(ConnectionBase connection, Throwable e) {
protected void setCseContext() {
try {
- String cseContext = JsonUtils.writeValueAsString(invocation.getContext());
+ String cseContext = JsonUtils.writeUnicodeValueAsString(invocation.getContext());
Review Comment:
I think it is compatible, Jackson will automatic decode unicode string in deserialization.
In testcase, use writeUnicodeValueAsString to serialize and use the old OBJ_MAPPER to deserialize, the value is not changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 commented on a diff in pull request #3009: [SCB-2533] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
liubao68 commented on code in PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009#discussion_r885127883
##########
transports/transport-rest/transport-rest-client/src/main/java/org/apache/servicecomb/transport/rest/client/http/RestClientInvocation.java:
##########
@@ -274,7 +274,7 @@ protected void fail(ConnectionBase connection, Throwable e) {
protected void setCseContext() {
try {
- String cseContext = JsonUtils.writeValueAsString(invocation.getContext());
+ String cseContext = JsonUtils.writeUnicodeValueAsString(invocation.getContext());
Review Comment:
Can you add some unit test case for this and create a PR for master? I'd prefer not merge this for 1.x.
test cases:
1. encode(ascii or unicode) with this feature enabled, decode with this feature disabled
2. encode(ascii or unicode) with this feature disabled, decode with this feature disabled (1, 2 will get same result)
3. while users encode unicode first, and add to context, encode(ascii or unicode) with this feature disabled
4. while users encode unicode first, and add to context, encode(ascii or unicode) with this feature enabled (3, 4 will get same result)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #3009: [SCB-2533] [1.3.x] encode invocation context before add to http header
Posted by GitBox <gi...@apache.org>.
liubao68 merged PR #3009:
URL: https://github.com/apache/servicecomb-java-chassis/pull/3009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org