You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "s0nskar (via GitHub)" <gi...@apache.org> on 2024/09/26 12:01:41 UTC

[PR] [CELEBORN-1617] Support workers tags in FS Config Service [celeborn]

s0nskar opened a new pull request, #2766:
URL: https://github.com/apache/celeborn/pull/2766

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   Adding support for reading worker tags in FSConfigService. (Will handle DBConfigService in separate PR). Tags will be part of System level config and  dynamic config file structure with tags is shown below:
   
   ```
   -  level: SYSTEM
      config:
        celeborn.test.int.only: 100
      tags:
        tag1:
          - 'host1:1111'
          - 'host2:2222'
        tag2:
          - 'host3:3333'
          - 'host4:4444'
   ```
   
   ### Why are the changes needed?
   
   https://cwiki.apache.org/confluence/display/CELEBORN/CIP-11+Supporting+Tags+in+Celeborn
   
   ### Does this PR introduce _any_ user-facing change?
   
   - Changes are backward compatible.
   - User will be able to pass worker tags from dynamicConfig.yaml file.
   
   
   ### How was this patch tested?
   UTs
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1617][CIP-11] Support workers tags in FS Config Service [celeborn]

Posted by "s0nskar (via GitHub)" <gi...@apache.org>.
s0nskar commented on PR #2766:
URL: https://github.com/apache/celeborn/pull/2766#issuecomment-2376781918

   I've made tags part of SystemConfig as it made more sense to me, let me know if you think if it should extracted out as a separate config something like below.
   
   ```
   -  tags:
        tag1:
          - 'host1:1111'
          - 'host2:2222'
        tag2:
          - 'host3:3333'
          - 'host4:4444'
   ```
   
   cc: @FMX @zwangsheng @mridulm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1617][CIP-11] Support workers tags in FS Config Service [celeborn]

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2766: [CELEBORN-1617][CIP-11] Support workers tags in FS Config Service
URL: https://github.com/apache/celeborn/pull/2766


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org