You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/23 14:28:01 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval

clebertsuconic commented on a change in pull request #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval
URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r396491608
 
 

 ##########
 File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java
 ##########
 @@ -308,9 +308,7 @@ private static ServerJMSMessage processApplicationProperties(ServerJMSMessage jm
    private static ServerJMSMessage processExtraProperties(ServerJMSMessage jms, TypedProperties properties) {
       if (properties != null) {
          properties.forEach((k, v) -> {
-            if (!k.equals(AMQPMessage.ADDRESS_PROPERTY)) {
 
 Review comment:
   why?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services