You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Nathan Beyer (JIRA)" <ji...@apache.org> on 2006/04/02 05:13:26 UTC
[jira] Created: (HARMONY-292) [classlib][luni-kernel] Update String
for Java 5 and StringTest
[classlib][luni-kernel] Update String for Java 5 and StringTest
---------------------------------------------------------------
Key: HARMONY-292
URL: http://issues.apache.org/jira/browse/HARMONY-292
Project: Harmony
Type: Improvement
Components: Classlib
Reporter: Nathan Beyer
Updates to java.lang.String to implement most of the new Java 5 methods and constructors. I didn't quite know how to test these changes, since I don't have a VM impl that I can control. However, I did update the "API" test case in LUNI with tests for these new methods and ran them against Sun's Java 5 JRE v5.0_5 to verify them, which can be run later to validate the changes to String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-292) [classlib][luni-kernel] Update String
for Java 5 and StringTest
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-292?page=all ]
Nathan Beyer updated HARMONY-292:
---------------------------------
Attachment: String_java_5_patch.txt
StringTest_java_5_patch.txt
String_java_5_patch.txt - luni-kernel
StringTest_java_5_patch.txt - luni
> [classlib][luni-kernel] Update String for Java 5 and StringTest
> ---------------------------------------------------------------
>
> Key: HARMONY-292
> URL: http://issues.apache.org/jira/browse/HARMONY-292
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Attachments: StringTest_java_5_patch.txt, String_java_5_patch.txt
>
> Updates to java.lang.String to implement most of the new Java 5 methods and constructors. I didn't quite know how to test these changes, since I don't have a VM impl that I can control. However, I did update the "API" test case in LUNI with tests for these new methods and ran them against Sun's Java 5 JRE v5.0_5 to verify them, which can be run later to validate the changes to String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-292) [classlib][luni-kernel] Update String
for Java 5 and StringTest
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-292?page=all ]
Nathan Beyer updated HARMONY-292:
---------------------------------
Attachment: String_java_5_patch_2.txt
My original patch for String was posted incorrectly, so I'm posting this replacement. Also, this patch is based against the String that's now in luni.
> [classlib][luni-kernel] Update String for Java 5 and StringTest
> ---------------------------------------------------------------
>
> Key: HARMONY-292
> URL: http://issues.apache.org/jira/browse/HARMONY-292
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Attachments: StringTest_java_5_patch.txt, String_java_5_patch.txt, String_java_5_patch_2.txt
>
> Updates to java.lang.String to implement most of the new Java 5 methods and constructors. I didn't quite know how to test these changes, since I don't have a VM impl that I can control. However, I did update the "API" test case in LUNI with tests for these new methods and ran them against Sun's Java 5 JRE v5.0_5 to verify them, which can be run later to validate the changes to String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-292) [classlib][luni-kernel] Update String
for Java 5 and StringTest
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-292?page=all ]
Nathan Beyer updated HARMONY-292:
---------------------------------
Attachment: String_java_5_methods3.txt
This patch (3) replaces all other patches.
> [classlib][luni-kernel] Update String for Java 5 and StringTest
> ---------------------------------------------------------------
>
> Key: HARMONY-292
> URL: http://issues.apache.org/jira/browse/HARMONY-292
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Attachments: StringTest_java_5_patch.txt, String_java_5_methods3.txt, String_java_5_patch.txt, String_java_5_patch_2.txt
>
> Updates to java.lang.String to implement most of the new Java 5 methods and constructors. I didn't quite know how to test these changes, since I don't have a VM impl that I can control. However, I did update the "API" test case in LUNI with tests for these new methods and ran them against Sun's Java 5 JRE v5.0_5 to verify them, which can be run later to validate the changes to String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-292) [classlib][luni-kernel] Update
String for Java 5 and StringTest
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-292?page=comments#action_12376634 ]
Nathan Beyer commented on HARMONY-292:
--------------------------------------
Looks good to me, thank you.
> [classlib][luni-kernel] Update String for Java 5 and StringTest
> ---------------------------------------------------------------
>
> Key: HARMONY-292
> URL: http://issues.apache.org/jira/browse/HARMONY-292
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Assignee: Tim Ellison
> Attachments: StringTest.java, StringTest_java_5_patch.txt, String_JIRA_292_patch.txt, String_java_5_methods3.txt, String_java_5_patch.txt, String_java_5_patch_2.txt
>
> Updates to java.lang.String to implement most of the new Java 5 methods and constructors. I didn't quite know how to test these changes, since I don't have a VM impl that I can control. However, I did update the "API" test case in LUNI with tests for these new methods and ran them against Sun's Java 5 JRE v5.0_5 to verify them, which can be run later to validate the changes to String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-292) [classlib][luni-kernel] Update
String for Java 5 and StringTest
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-292?page=all ]
Tim Ellison resolved HARMONY-292:
---------------------------------
Resolution: Fixed
Thanks Nathan,
Patch applied to LUNI module java.lang.String at repo revision 397239.
Please check that the patch was applied as you expected.
> [classlib][luni-kernel] Update String for Java 5 and StringTest
> ---------------------------------------------------------------
>
> Key: HARMONY-292
> URL: http://issues.apache.org/jira/browse/HARMONY-292
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Assignee: Tim Ellison
> Attachments: StringTest.java, StringTest_java_5_patch.txt, String_JIRA_292_patch.txt, String_java_5_methods3.txt, String_java_5_patch.txt, String_java_5_patch_2.txt
>
> Updates to java.lang.String to implement most of the new Java 5 methods and constructors. I didn't quite know how to test these changes, since I don't have a VM impl that I can control. However, I did update the "API" test case in LUNI with tests for these new methods and ran them against Sun's Java 5 JRE v5.0_5 to verify them, which can be run later to validate the changes to String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-292) [classlib][luni-kernel] Update
String for Java 5 and StringTest
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-292?page=all ]
Tim Ellison reassigned HARMONY-292:
-----------------------------------
Assign To: Tim Ellison
> [classlib][luni-kernel] Update String for Java 5 and StringTest
> ---------------------------------------------------------------
>
> Key: HARMONY-292
> URL: http://issues.apache.org/jira/browse/HARMONY-292
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Assignee: Tim Ellison
> Attachments: StringTest_java_5_patch.txt, String_java_5_methods3.txt, String_java_5_patch.txt, String_java_5_patch_2.txt
>
> Updates to java.lang.String to implement most of the new Java 5 methods and constructors. I didn't quite know how to test these changes, since I don't have a VM impl that I can control. However, I did update the "API" test case in LUNI with tests for these new methods and ran them against Sun's Java 5 JRE v5.0_5 to verify them, which can be run later to validate the changes to String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-292) [classlib][luni-kernel] Update String
for Java 5 and StringTest
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-292?page=all ]
Nathan Beyer updated HARMONY-292:
---------------------------------
Attachment: String_JIRA_292_patch.txt
StringTest.java
StringTest.java - Test case for the new String constructors and methods. This is in the o.a.h.test.java.lang package, as per the suggested practices. I've created a "newString" method that uses the package scope constructor, so that I can test the use cases where offset is greater than 1. These test, if desired, can be refactored to be part of the "java.lang" package.
String_JIRA_292_patch.txt - The patch to String to add the new constructors and methods.
Please ignore all other attachments. Sorry for the mess.
> [classlib][luni-kernel] Update String for Java 5 and StringTest
> ---------------------------------------------------------------
>
> Key: HARMONY-292
> URL: http://issues.apache.org/jira/browse/HARMONY-292
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Assignee: Tim Ellison
> Attachments: StringTest.java, StringTest_java_5_patch.txt, String_JIRA_292_patch.txt, String_java_5_methods3.txt, String_java_5_patch.txt, String_java_5_patch_2.txt
>
> Updates to java.lang.String to implement most of the new Java 5 methods and constructors. I didn't quite know how to test these changes, since I don't have a VM impl that I can control. However, I did update the "API" test case in LUNI with tests for these new methods and ran them against Sun's Java 5 JRE v5.0_5 to verify them, which can be run later to validate the changes to String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-292) [classlib][luni-kernel] Update String
for Java 5 and StringTest
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-292?page=all ]
Tim Ellison closed HARMONY-292:
-------------------------------
Verified by Nathan
> [classlib][luni-kernel] Update String for Java 5 and StringTest
> ---------------------------------------------------------------
>
> Key: HARMONY-292
> URL: http://issues.apache.org/jira/browse/HARMONY-292
> Project: Harmony
> Type: Improvement
> Components: Classlib
> Reporter: Nathan Beyer
> Assignee: Tim Ellison
> Attachments: StringTest.java, StringTest_java_5_patch.txt, String_JIRA_292_patch.txt, String_java_5_methods3.txt, String_java_5_patch.txt, String_java_5_patch_2.txt
>
> Updates to java.lang.String to implement most of the new Java 5 methods and constructors. I didn't quite know how to test these changes, since I don't have a VM impl that I can control. However, I did update the "API" test case in LUNI with tests for these new methods and ran them against Sun's Java 5 JRE v5.0_5 to verify them, which can be run later to validate the changes to String.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira