You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/03 21:34:25 UTC

[GitHub] [kafka] mumrah opened a new pull request, #12483: KAFKA-14136 Generate ConfigRecord even if the value is unchanged

mumrah opened a new pull request, #12483:
URL: https://github.com/apache/kafka/pull/12483

   This patch changes the AlterConfigs behavior in KRaft mode to match that of ZK. When we receive a LegacyAlterConfig or IncrementalAlterConfig that does _not_ change a value for a key, we will still generate a ConfigRecord.
   
   This is to allow certain refresh behavior on the broker side (e.g., reloading trust stores and key stores).
   
   The DynamicBrokerReconfigurationTests which reload key stores and trust stores are enabled in this PR to validate the new behavior.
   
   Also, a small fix for KAFKA-14115 is included.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] cmccabe commented on pull request #12483: KAFKA-14136 Generate ConfigRecord even if the value is unchanged

Posted by GitBox <gi...@apache.org>.
cmccabe commented on PR #12483:
URL: https://github.com/apache/kafka/pull/12483#issuecomment-1204544001

   Can we do this just for the broker configs? We don't have this behavior for topic configs or other types of configs...
   
   LGTM other than that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] mumrah merged pull request #12483: KAFKA-14136 Generate ConfigRecord even if the value is unchanged

Posted by GitBox <gi...@apache.org>.
mumrah merged PR #12483:
URL: https://github.com/apache/kafka/pull/12483


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org