You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/12/01 01:45:22 UTC
Review Request 54238: Added `getContainerIOSwitchboardAddress` helper
to containerizer paths.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54238/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-6467
https://issues.apache.org/jira/browse/MESOS-6467
Repository: mesos
Description
-------
Added `getContainerIOSwitchboardAddress` helper to containerizer paths.
Diffs
-----
src/slave/containerizer/mesos/paths.hpp 44df6c0beeee74e38140a9e6037c103a7f8c6d16
src/slave/containerizer/mesos/paths.cpp 422fb80ced8e6435a714d32e3ee9b72874e2034d
Diff: https://reviews.apache.org/r/54238/diff/
Testing
-------
make check
Thanks,
Kevin Klues
Re: Review Request 54238: Added `getContainerIOSwitchboardAddress`
helper to containerizer paths.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54238/#review157555
-----------------------------------------------------------
Bad patch!
Reviews applied: [54238, 54148, 54147, 54053]
Failed command: ./support/apply-review.sh -n -r 54148
Error:
2016-12-01 06:35:07 URL:https://reviews.apache.org/r/54148/diff/raw/ [13977/13977] -> "54148.patch" [1]
error: patch failed: src/slave/containerizer/mesos/io/switchboard.hpp:63
error: src/slave/containerizer/mesos/io/switchboard.hpp: patch does not apply
error: patch failed: src/slave/containerizer/mesos/io/switchboard.cpp:114
error: src/slave/containerizer/mesos/io/switchboard.cpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/16286/console
- Mesos ReviewBot
On Dec. 1, 2016, 1:45 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54238/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 1:45 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6467
> https://issues.apache.org/jira/browse/MESOS-6467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `getContainerIOSwitchboardAddress` helper to containerizer paths.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp 44df6c0beeee74e38140a9e6037c103a7f8c6d16
> src/slave/containerizer/mesos/paths.cpp 422fb80ced8e6435a714d32e3ee9b72874e2034d
>
> Diff: https://reviews.apache.org/r/54238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 54238: Added `getContainerIOSwitchboardAddress`
helper to containerizer paths.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54238/#review157527
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 1, 2016, 1:45 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54238/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 1:45 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-6467
> https://issues.apache.org/jira/browse/MESOS-6467
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `getContainerIOSwitchboardAddress` helper to containerizer paths.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/paths.hpp 44df6c0beeee74e38140a9e6037c103a7f8c6d16
> src/slave/containerizer/mesos/paths.cpp 422fb80ced8e6435a714d32e3ee9b72874e2034d
>
> Diff: https://reviews.apache.org/r/54238/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Kevin Klues
>
>