You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2015/07/30 14:26:48 UTC

[GitHub] tajo pull request: TAJO-1723: INSERT INTO statement should allow n...

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/668

    TAJO-1723: INSERT INTO statement should allow nested fields as target columns.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-1723

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/668.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #668
    
----
commit 5faaeccdf3e1ccffa445107ac65ed6a0cef11f54
Author: Hyunsik Choi <hy...@apache.org>
Date:   2015-07-30T11:00:12Z

    initial work
    
     * Improve SQL parser to recognize nested target fields in INSERT INTO statement.
     * Add workaround for hanging TaskContainer.
     * Improve logical planner to recognize nested target fields in INSERT INTO statement.

commit ef499b3dffa846d31462c5a4be9042d83eec9ed1
Author: Hyunsik Choi <hy...@apache.org>
Date:   2015-07-30T12:21:33Z

    TAJO-1723: INSERT INTO statement should allow nested fields as target columns.

commit 334db6d0cf471fd1f00a41ee44133ac70d1153e6
Author: Hyunsik Choi <hy...@apache.org>
Date:   2015-07-30T12:23:43Z

    Refine changes.

commit e9acd683a1e075c20bc78ca26058a84b1305b078
Author: Hyunsik Choi <hy...@apache.org>
Date:   2015-07-30T12:24:57Z

    Moved some methods to SchemaUtil.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1723: INSERT INTO statement should allow n...

Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/668#issuecomment-127497646
  
    +1 Looks great to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1723: INSERT INTO statement should allow n...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/668#issuecomment-126306890
  
    TestSelectNestedRecord contains some insertion tests. Its purpose is not matched to the class name. I wanted to merge all unit tests related to nested fields into one test. Later, I'll move them into more proper one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1723: INSERT INTO statement should allow n...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/668


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---