[GitHub] [dolphinscheduler] chengshiwen commented on a change in pull request #5829: [Fix-5830][Improvement][UI] Improve the selection style in dag edit dialog

[GitBox <gi...@apache.org>]

chengshiwen commented on a change in pull request #5829:
URL: https://github.com/apache/dolphinscheduler/pull/5829#discussion_r675358209



##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/udp/udp.vue
##########
@@ -251,6 +251,19 @@
       max-height: 600px;
       overflow-y: scroll;
       padding:0 20px;
+
+      ::selection {
+        background: #409EFF ;
+        color: white;
+      }
+      ::-moz-selection {

Review comment:
       Please remove `::-moz-selection` and `::-webkit-selection`

##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.vue
##########
@@ -893,4 +893,22 @@
   .operBtn {
     padding: 8px 6px;
   }
+
+  .el-drawer__body {
+    ::selection {
+      background: #409EFF;
+      color: white;
+    }
+
+    ::-moz-selection {

Review comment:
       Please remove `::-moz-selection` and `::-webkit-selection`, `postcss-loader` and `autoprefixer` will help add the prefixes when building




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org