[GitHub] [pulsar] Anonymitaet commented on a change in pull request #11139: [Issue 10896] add get message id by timestamp

[GitBox <gi...@apache.org>]

Anonymitaet commented on a change in pull request #11139:
URL: https://github.com/apache/pulsar/pull/11139#discussion_r660453233



##########
File path: site2/docs/admin-api-topics.md
##########
@@ -538,6 +538,31 @@ admin.topics().getMessageById(topic, ledgerId, entryId);
 
 <!--END_DOCUSAURUS_CODE_TABS-->
 
+### Get message ID 
+
+You can get message id published at or just after the given datetime.
+
+<!--DOCUSAURUS_CODE_TABS-->
+<!--pulsar-admin-->
+```shell
+$ ./bin/pulsar-admin topics get-message-id \

Review comment:
       ```suggestion
   ./bin/pulsar-admin topics get-message-id \
   ```
   
   Remove $ so that users can copy the command directly and conveniently.  

##########
File path: pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -1349,6 +1349,28 @@ void expireMessagesForAllSubscriptions(String topic, long expireTimeInSeconds)
      */
     CompletableFuture<Message<byte[]>> getMessageByIdAsync(String topic, long ledgerId, long entryId);
 
+    /**
+     * Get message id by timestamp.

Review comment:
       ```suggestion
        * Get message ID by timestamp.
   ```
   
   Pls pay attention to capitalization and correct all occurrences, thanks. 

##########
File path: site2/docs/admin-api-topics.md
##########
@@ -538,6 +538,31 @@ admin.topics().getMessageById(topic, ledgerId, entryId);
 
 <!--END_DOCUSAURUS_CODE_TABS-->
 
+### Get message ID 
+
+You can get message id published at or just after the given datetime.

Review comment:
       Why the description here is different from the previous one (`Get message ID by timestamp`)?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org