You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2018/09/11 10:48:19 UTC
[GitHub] brooklyn-server pull request #989: LogWatcher - don't change log level if no...
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/989
LogWatcher - don't change log level if not needed
prevents the logs from missing useful output if testing for a higher-level message,
useful when investigating tests, esp SoftwareProcessStopsDuringStartTest.testStopDuringProvisionWaitsForCompletion where the log messages we want aren't showing because we reset it to warn.
also use try-close syntax for LogWatcher.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server fix-tests-and-log-watcher
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/989.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #989
----
commit 6d42fb35234b82c32ea96fa25885d0942673ddda
Author: Alex Heneveld <al...@...>
Date: 2018-09-11T10:36:48Z
LogWatcher don't change log level if not needed
prevents the logs from missing useful output if testing for a higher-level message,
useful when investigating tests.
also use try-close syntax for LogWatcher.
----
---
[GitHub] brooklyn-server pull request #989: LogWatcher - don't change log level if no...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/989
---
[GitHub] brooklyn-server pull request #989: LogWatcher - don't change log level if no...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/989#discussion_r218311895
--- Diff: test-support/src/main/java/org/apache/brooklyn/test/LogWatcher.java ---
@@ -268,17 +248,14 @@ public void assertHasEvent() {
@Override
public void run() {
assertFalse(events.isEmpty());
+ System.out.println("EVENTS: "+events);
--- End diff --
Don't include `System.out`
---
[GitHub] brooklyn-server issue #989: LogWatcher - don't change log level if not neede...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/989
thx @aledsage , done and merged
---