You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ke...@apache.org on 2020/02/19 12:21:39 UTC

[skywalking] branch kezhenxu94-patch-1 created (now a5efe85)

This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a change to branch kezhenxu94-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git.


      at a5efe85  Update committer review and merge guide

This branch includes the following new commits:

     new a5efe85  Update committer review and merge guide

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[skywalking] 01/01: Update committer review and merge guide

Posted by ke...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

kezhenxu94 pushed a commit to branch kezhenxu94-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit a5efe852521acedef0c304f7999837afc3f0a193
Author: kezhenxu94 <ke...@apache.org>
AuthorDate: Wed Feb 19 20:21:31 2020 +0800

    Update committer review and merge guide
---
 docs/en/guides/asf/committer.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/en/guides/asf/committer.md b/docs/en/guides/asf/committer.md
index 27654a4..c712685 100644
--- a/docs/en/guides/asf/committer.md
+++ b/docs/en/guides/asf/committer.md
@@ -121,11 +121,11 @@ Notice, if never got your GitHub invitation? Visit github.com/apache to see if y
 If you want others could see you are in the Apache GitHub org, you need to go to [Apache GitHub org people page](https://github.com/orgs/apache/people), 
 search for yourself, and choose `Organization visibility` to `Public`.
 
-### Committer right, duty and responsibility
+### Committer rights, duties and responsibilities
 SkyWalking project doesn't require the continue contributions after you become a committer, but we hope and truly want you could.
 
 Being a committer, you could
-1. Review and merge the pull request to the master branch in the Apache repo. For new committer, we hope you could request some senior committer to recheck the pull request.
+1. Review and merge the pull request to the master branch in the Apache repo. A pull request often contains multiple commits. Those commits **must be squashed and merged** into a single commit **with explanatory comments**. For new committer, we hope you could request some senior committer to recheck the pull request.
 1. Create and push codes to new branch in the Apache repo.
 1. Follow the [Release process](../How-to-release.md) to process new release. Of course, you need to ask committer team
 to confirm it is the right time to release.