You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "febilus (via GitHub)" <gi...@apache.org> on 2024/02/11 13:59:15 UTC
[PR] [NETBEANS-6997] Adding support for Wildfly 31 [netbeans]
febilus opened a new pull request, #7055:
URL: https://github.com/apache/netbeans/pull/7055
- extract method for read ManifestAttributes from wildfly-feature-pack-product-conf jar file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "febilus (via GitHub)" <gi...@apache.org>.
febilus commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1962724026
Many Thanks for the explanation/help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "troizet (via GitHub)" <gi...@apache.org>.
troizet commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1966240337
This fix will be available in Apache NetBeans 22.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1962337645
tests are green, PR is reviewed and squashed -> merging
@febilus congrats to your first contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "mrcasio (via GitHub)" <gi...@apache.org>.
mrcasio commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-2361272391
Thank you for the work on this PR! Unfortunately, it seems that this solution does not work for subsequent versions of WildFly. As mentioned in the Apache mailing list (source: https://lists.apache.org/thread/53k67ndngnf1fobfo1jzmo3cqb5ny3m2), the issue has resurfaced with WildFly 32 and WildFly 33. Specifically, NetBeans 22 looks for `MANIFEST.MF` in the `wildfly-feature-pack-product-conf-31.0.0.Final.jar`, which works for WildFly 31 but fails for later versions due to the file-name changes (e.g., `wildfly-feature-pack-product-conf-33.0.0.Final.jar` for WildFly 33). The user who reported this issue hopes for a similar solution to PR #7055, potentially for NetBeans 23, to enable compatibility with WildFly 33, which supports Java 21.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "febilus (via GitHub)" <gi...@apache.org>.
febilus commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1962330138
Hi @mbien , I got a question, because I think I did a small mistake.
After I took your suggestion I did a mistake: I updated my master and merged the master in the wildfly branch. Then I was not able to squash the last 2 commits together.
To resolve this I reset the merge with the master and squashed the changes together.
Now I'm not sure if I the PR is ready to use it, or do I have to update and merge the master into my branch again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1966300641
dev builds for the next release are also linked from the readme: https://github.com/apache/netbeans?tab=readme-ov-file#download
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1962335042
hi @febilus, you did good since I see only one commit in your branch - so the squashing worked.
the branch is a few weeks old but I think this shouldn't matter here since the Wildfly area has low traffic.
in future: lets say the PR is reviewed and someone asks you to squash the PR to make it ready to integration you can do the following:
you could update your branch (rewrite history) and put your commits on top of latest changes **without a merge commit**, all you have to do is:
```
git pull --rebase git@github.com:apache/netbeans master
```
(this assumes you have the PR branch checked out)
(you can also use origin alias if it points at the apache repo)
(this will also get rid of any existing merge commits, if there are any)
Now its easy to squash the commits however you like them to be (in most cases it will be just one commit).
Also keep in mind other projects might have a different policy, some don't allow force pushes and let the person who integrates the PR squash it etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #7055:
URL: https://github.com/apache/netbeans/pull/7055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "morvael (via GitHub)" <gi...@apache.org>.
morvael commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1977341530
To test it or just switch for production work as workaround?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-2362724872
the manifest issue will likely by fixed by https://github.com/apache/netbeans/pull/7772, if this goes beyond the changed manifest name, please file a separate issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "SimonePadovan (via GitHub)" <gi...@apache.org>.
SimonePadovan commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1968394562
thank you very much !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1977220016
@morvael you could give the dev builds a try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "morvael (via GitHub)" <gi...@apache.org>.
morvael commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1976258854
Too bad such things can't be released via Netbeans Update mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1960342827
@febilus could you squash all commits and force push into the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#discussion_r1493821233
##########
enterprise/javaee.wildfly/src/org/netbeans/modules/javaee/wildfly/ide/ui/WildflyPluginUtils.java:
##########
@@ -435,6 +431,29 @@ public static boolean isWildFlyJakartaEE(File serverPath) {
return jakartaDir.exists();
}
+ private static Attributes findManifestAttributes(File serverPath, String slot) {
+ File productDir = new File(serverPath, getModulesBase(serverPath.getAbsolutePath()) + "org.jboss.as.product".replace('.', separatorChar) + separatorChar + slot);
+ File[] files = productDir.listFiles();
+ for (File file : files) {
+ try {
+ if (file.getName().startsWith("wildfly-feature-pack-product-conf") && file.getName().endsWith(".jar")) {
+ JarFileSystem featurePackProductConfJar = new JarFileSystem(file);
+ return featurePackProductConfJar.getManifest().getMainAttributes();
+ }
+ } catch (Exception ignore) {
+ }
+ }
+ File manifestFile = new File(serverPath, getModulesBase(serverPath.getAbsolutePath()) + "org.jboss.as.product".replace('.', separatorChar) + separatorChar + slot + separatorChar + "dir" + separatorChar + "META-INF" + separatorChar + "MANIFEST.MF");
Review Comment:
```suggestion
File manifestFile = new File(productDir, "dir" + separatorChar + "META-INF" + separatorChar + "MANIFEST.MF");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Adding support for Wildfly 31 [netbeans]
Posted by "SimonePadovan (via GitHub)" <gi...@apache.org>.
SimonePadovan commented on PR #7055:
URL: https://github.com/apache/netbeans/pull/7055#issuecomment-1966225815
When will this fix be available ? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists