You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2020/10/14 08:45:19 UTC
[GitHub] [james-project] aasaru opened a new pull request #253: JAMES-3398 add Maven wrapper (with latest Maven version 3.6.3)
aasaru opened a new pull request #253:
URL: https://github.com/apache/james-project/pull/253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #253: JAMES-3398 add Maven wrapper (with latest Maven version 3.6.3)
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #253:
URL: https://github.com/apache/james-project/pull/253#issuecomment-811849739
Note that maven 3.7.x and 3.8.x seem to have been abandonned in favor of maven 4.0.x
There is an alpha snapshot floating around for fearless osx using people : https://maarten.mulders.it/2020/11/whats-new-in-maven-4/ there is also probably a way to use it on linux...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] aasaru commented on pull request #253: JAMES-3398 add Maven wrapper (with latest Maven version 3.6.3)
Posted by GitBox <gi...@apache.org>.
aasaru commented on pull request #253:
URL: https://github.com/apache/james-project/pull/253#issuecomment-708627272
@chibenwa , fair points both, I agree with you. I now removed the binary and added separate section to readme.
I also improved the readme a bit. I investigated why IntelliJ IDEA complains about Readme.adoc and fixed some of the problems it pointed out (I couldn't fix titles that contain "+" sign so IntelliJ IDEA will still complain about those)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #253: JAMES-3398 add Maven wrapper (with latest Maven version 3.6.3)
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #253:
URL: https://github.com/apache/james-project/pull/253#issuecomment-752241998
A quick search yielded https://github.com/bdemers/maven-wrapper superseded by https://github.com/takari/maven-wrapper which itself mentions:
> The project codebase has been accepted to be included in the upstream Apache Maven project itself. Currently the plan is to release the wrapper as a feature of the upcoming Maven 3.7.0 release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #253: JAMES-3398 add Maven wrapper (with latest Maven version 3.6.3)
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #253:
URL: https://github.com/apache/james-project/pull/253#discussion_r510669086
##########
File path: .mvn/wrapper/MavenWrapperDownloader.java
##########
@@ -0,0 +1,117 @@
+/*
+ * Copyright 2007-present the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import java.net.*;
+import java.io.*;
+import java.nio.channels.*;
+import java.util.Properties;
+
Review comment:
I understand this code is copied but can we have a link to the place it was copied from as a comment?
This helps code patternity.
This helps checking divergences from the original version.
##########
File path: mvnw.cmd
##########
@@ -0,0 +1,182 @@
+@REM ----------------------------------------------------------------------------
+@REM Licensed to the Apache Software Foundation (ASF) under one
+@REM or more contributor license agreements. See the NOTICE file
+@REM distributed with this work for additional information
+@REM regarding copyright ownership. The ASF licenses this file
+@REM to you under the Apache License, Version 2.0 (the
+@REM "License"); you may not use this file except in compliance
+@REM with the License. You may obtain a copy of the License at
+@REM
+@REM http://www.apache.org/licenses/LICENSE-2.0
+@REM
+@REM Unless required by applicable law or agreed to in writing,
+@REM software distributed under the License is distributed on an
+@REM "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+@REM KIND, either express or implied. See the License for the
+@REM specific language governing permissions and limitations
+@REM under the License.
+@REM ----------------------------------------------------------------------------
+
Review comment:
URL?
##########
File path: mvnw
##########
@@ -0,0 +1,310 @@
+#!/bin/sh
+# ----------------------------------------------------------------------------
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# ----------------------------------------------------------------------------
+
Review comment:
Idem, I would welcome a URL from where this was copied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org