[GitHub] [beam] robertwb commented on a diff in pull request #21915: convert windmill min timestamp to beam min timestamp

[GitBox <gi...@apache.org>]

robertwb commented on code in PR #21915:
URL: https://github.com/apache/beam/pull/21915#discussion_r922463977


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimeUtils.java:
##########
@@ -42,13 +42,23 @@ public class WindmillTimeUtils {
    * round timestamps down and output watermarks up.
    */
   public static Instant windmillToHarnessTimestamp(long timestampUs) {
+    System.out.println("check if need to bound timestamp: " + String.valueOf(timestampUs));

Review Comment:
   Remove these debugging statements?



##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java:
##########
@@ -351,12 +356,25 @@ public static TimerData windmillTimerToTimerData(
 
     // For backwards compatibility, handle the case were the output timestamp isn't present.
     Instant outputTimestamp = timestamp;
+    System.out.println("coumputed timestamp: " + String.valueOf(timestamp));
+    System.out.println("coumputed outputTimestamp: " + String.valueOf(outputTimestamp));
+
     if ((outputTimestampStart < tag.size())) {
       try {
         outputTimestamp =
             new Instant(
                 VarInt.decodeLong(
                     tag.substring(outputTimestampStart, outputTimestampEnd).newInput()));
+        System.out.println(
+            "parsed string"
+                + String.valueOf(
+                    tag.substring(outputTimestampStart, outputTimestampEnd).newInput()));
+        if (outputTimestamp.isBefore(BoundedWindow.TIMESTAMP_MIN_VALUE)) {

Review Comment:
   Can we re-use the code above?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org