[GitHub] [sling-org-apache-sling-distribution-journal] cschneider commented on a change in pull request #90: SLING-10095 - Surface latest content package extractor error in the e…

[GitBox <gi...@apache.org>]

cschneider commented on a change in pull request #90:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/90#discussion_r771433558



##########
File path: src/main/java/org/apache/sling/distribution/journal/bookkeeper/ContentPackageExtractor.java
##########
@@ -115,4 +121,12 @@ private void installPackage(JcrPackage pack) throws RepositoryException, Package
         }
     }
 
+    private void failed(@Nullable String errorMsg, PackageException e) throws PackageException {

Review comment:
       That is a case where even I would consider inlining as the code inside the method is very small but not a big issue.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org