You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/12/12 01:39:42 UTC
Re: Review Request 41004: Logger Module: Introduce the ContainerLogger
module.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41004/
-----------------------------------------------------------
(Updated Dec. 11, 2015, 4:39 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Rename from ExecutorLogger to ContainerLogger.
Summary (updated)
-----------------
Logger Module: Introduce the ContainerLogger module.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description (updated)
-------
Modularizes the `ContainerLogger` interface and adds the `SandboxContainerLogger` as the default.
Diffs (updated)
-----
include/mesos/module/container_logger.hpp PRE-CREATION
src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e
src/examples/test_container_logger_module.cpp PRE-CREATION
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/slave/container_logger.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/41004/diff/
Testing (updated)
-------
make
Tests are modified and run later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41004: Logger Module: Introduce the ContainerLogger
module.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41004/#review112201
-----------------------------------------------------------
Ship it!
I'll fix the indent and commit, thanks!
src/examples/test_container_logger_module.cpp (line 40)
<https://reviews.apache.org/r/41004/#comment172534>
No indent here please.
- Benjamin Hindman
On Dec. 22, 2015, 12:49 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41004/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2015, 12:49 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
>
>
> Bugs: MESOS-4087
> https://issues.apache.org/jira/browse/MESOS-4087
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modularizes the `ContainerLogger` interface and adds the `SandboxContainerLogger` as the default.
>
>
> Diffs
> -----
>
> include/mesos/module/container_logger.hpp PRE-CREATION
> src/Makefile.am cf7f950c0c320a6c8e956409a35a7f47d905f71d
> src/examples/test_container_logger_module.cpp PRE-CREATION
> src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
> src/slave/container_logger.cpp PRE-CREATION
> src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
> src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
>
> Diff: https://reviews.apache.org/r/41004/diff/
>
>
> Testing
> -------
>
> make
>
> Tests are modified and run later in the review chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41004: Logger Module: Introduce the ContainerLogger
module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41004/
-----------------------------------------------------------
(Updated Dec. 21, 2015, 4:49 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Remove runtime check `validate`.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
Modularizes the `ContainerLogger` interface and adds the `SandboxContainerLogger` as the default.
Diffs (updated)
-----
include/mesos/module/container_logger.hpp PRE-CREATION
src/Makefile.am cf7f950c0c320a6c8e956409a35a7f47d905f71d
src/examples/test_container_logger_module.cpp PRE-CREATION
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/slave/container_logger.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/41004/diff/
Testing
-------
make
Tests are modified and run later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41004: Logger Module: Introduce the ContainerLogger
module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41004/
-----------------------------------------------------------
(Updated Dec. 20, 2015, 4:39 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Implement `ContainerLogger::validate`
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
Modularizes the `ContainerLogger` interface and adds the `SandboxContainerLogger` as the default.
Diffs (updated)
-----
include/mesos/module/container_logger.hpp PRE-CREATION
src/Makefile.am cf7f950c0c320a6c8e956409a35a7f47d905f71d
src/examples/test_container_logger_module.cpp PRE-CREATION
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/slave/container_logger.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/41004/diff/
Testing
-------
make
Tests are modified and run later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41004: Logger Module: Introduce the ContainerLogger
module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41004/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 12:14 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Lambda-ified a test module initializer. Renamed a local variable.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
Modularizes the `ContainerLogger` interface and adds the `SandboxContainerLogger` as the default.
Diffs (updated)
-----
include/mesos/module/container_logger.hpp PRE-CREATION
src/Makefile.am e6d48dc16135b5d147d036e851422686eff7d5ef
src/examples/test_container_logger_module.cpp PRE-CREATION
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/slave/container_logger.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/41004/diff/
Testing
-------
make
Tests are modified and run later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41004: Logger Module: Introduce the ContainerLogger
module.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41004/#review110832
-----------------------------------------------------------
Ship it!
src/examples/test_container_logger_module.cpp (line 56)
<https://reviews.apache.org/r/41004/#comment170838>
s/createContainerLogger/[](const Parameters& parameters) {
Try<ContainerLogger*> result = SandboxContainerLogger::create(None());
if (result.isError()) {
return NULL;
}
return result.get();
}/
src/slave/container_logger.cpp (line 37)
<https://reviews.apache.org/r/41004/#comment170841>
s/containerLogger/logger/
= NULL;
- Benjamin Hindman
On Dec. 15, 2015, 8:39 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41004/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 8:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
>
>
> Bugs: MESOS-4087
> https://issues.apache.org/jira/browse/MESOS-4087
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Modularizes the `ContainerLogger` interface and adds the `SandboxContainerLogger` as the default.
>
>
> Diffs
> -----
>
> include/mesos/module/container_logger.hpp PRE-CREATION
> src/Makefile.am acd17de04bce81f1d0550abfa0f43dec1a25fe7c
> src/examples/test_container_logger_module.cpp PRE-CREATION
> src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
> src/slave/container_logger.cpp PRE-CREATION
> src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
> src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
>
> Diff: https://reviews.apache.org/r/41004/diff/
>
>
> Testing
> -------
>
> make
>
> Tests are modified and run later in the review chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 41004: Logger Module: Introduce the ContainerLogger
module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41004/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 12:39 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Remove `options` in favor of module parameters.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
Modularizes the `ContainerLogger` interface and adds the `SandboxContainerLogger` as the default.
Diffs (updated)
-----
include/mesos/module/container_logger.hpp PRE-CREATION
src/Makefile.am acd17de04bce81f1d0550abfa0f43dec1a25fe7c
src/examples/test_container_logger_module.cpp PRE-CREATION
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/slave/container_logger.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/41004/diff/
Testing
-------
make
Tests are modified and run later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41004: Logger Module: Introduce the ContainerLogger
module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41004/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 12:10 p.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Fix a few copy-pasted comments.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
Modularizes the `ContainerLogger` interface and adds the `SandboxContainerLogger` as the default.
Diffs (updated)
-----
include/mesos/module/container_logger.hpp PRE-CREATION
src/Makefile.am acd17de04bce81f1d0550abfa0f43dec1a25fe7c
src/examples/test_container_logger_module.cpp PRE-CREATION
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/slave/container_logger.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/41004/diff/
Testing
-------
make
Tests are modified and run later in the review chain.
Thanks,
Joseph Wu
Re: Review Request 41004: Logger Module: Introduce the ContainerLogger
module.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41004/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 11:25 a.m.)
Review request for mesos, Benjamin Hindman, Cody Maloney, and Artem Harutyunyan.
Changes
-------
Changed `options` to an `Option<string>`. Moved call to `initialize` into `create`.
Bugs: MESOS-4087
https://issues.apache.org/jira/browse/MESOS-4087
Repository: mesos
Description
-------
Modularizes the `ContainerLogger` interface and adds the `SandboxContainerLogger` as the default.
Diffs (updated)
-----
include/mesos/module/container_logger.hpp PRE-CREATION
src/Makefile.am acd17de04bce81f1d0550abfa0f43dec1a25fe7c
src/examples/test_container_logger_module.cpp PRE-CREATION
src/module/manager.cpp 1f04790510a2ab9ccd6907fd01be192f52ee90c6
src/slave/container_logger.cpp PRE-CREATION
src/tests/module.hpp e46ed12c80707bf44ceef3ed1a4eb2f321ce10f6
src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828
Diff: https://reviews.apache.org/r/41004/diff/
Testing
-------
make
Tests are modified and run later in the review chain.
Thanks,
Joseph Wu