You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/25 17:33:05 UTC
[GitHub] [doris] emerkfu opened a new pull request, #11189: [doc] update get-starting.md
emerkfu opened a new pull request, #11189:
URL: https://github.com/apache/doris/pull/11189
# Proposed changes
Document formatting optimization, spelling correction.
## Problem Summary:
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (Yes)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on a diff in pull request #11189: [doc] update get-starting.md
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #11189:
URL: https://github.com/apache/doris/pull/11189#discussion_r930034330
##########
docs/zh-CN/docs/get-starting/get-starting.md:
##########
@@ -32,16 +32,15 @@ under the License.
1. CPU：2C（最低）8C（推荐）
2. 内存：4G（最低）48G（推荐）
3. 硬盘：100G（最低）400G（推荐）
-4. 平台：MacOS（Intel）、LinuxOS、Windows虚拟机
+4. 平台：MacOS（Intel）、LinuxOS、Windows 虚拟机
5. 系统：CentOS（7.1及以上）、Ubuntu（16.04 及以上）
6. 软件：JDK（1.8及以上）、GCC（4.8.2 及以上）
## 单机部署
-**在创建之前，请准备好已完成编译的FE/BE文件，此教程不再赘述编译过程。**
+**在创建之前，请准备好已完成编译的 FE / BE 文件，此教程不再赘述编译过程。**
-
-**该教程为单节点、1FE 和 1BE 的混布教程，只需要一个节点，便于快速体验 Doris。**
+**该教程为单节点、1 FE 和 1 BE 的混合部署教程，只需要一个节点，便于快速体验 Doris。**
Review Comment:
don't remove the empty line.
##########
docs/zh-CN/docs/get-starting/get-starting.md:
##########
@@ -32,16 +32,15 @@ under the License.
1. CPU：2C（最低）8C（推荐）
2. 内存：4G（最低）48G（推荐）
3. 硬盘：100G（最低）400G（推荐）
-4. 平台：MacOS（Intel）、LinuxOS、Windows虚拟机
+4. 平台：MacOS（Intel）、LinuxOS、Windows 虚拟机
5. 系统：CentOS（7.1及以上）、Ubuntu（16.04 及以上）
6. 软件：JDK（1.8及以上）、GCC（4.8.2 及以上）
## 单机部署
-**在创建之前，请准备好已完成编译的FE/BE文件，此教程不再赘述编译过程。**
+**在创建之前，请准备好已完成编译的 FE / BE 文件，此教程不再赘述编译过程。**
Review Comment:
redundant
##########
docs/en/docs/get-starting/get-starting.md:
##########
@@ -38,7 +38,7 @@ under the License.
## Stand-alone deployment
-**Before creating, please prepare the compiled FE/BE file, this tutorial will not repeat the compilation process.**
+**Before creating, please prepare the compiled FE / BE file, this tutorial will not repeat the compilation process.**
Review Comment:
It's redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] emerkfu commented on a diff in pull request #11189: [doc] update get-starting.md
Posted by GitBox <gi...@apache.org>.
emerkfu commented on code in PR #11189:
URL: https://github.com/apache/doris/pull/11189#discussion_r930136810
##########
docs/zh-CN/docs/get-starting/get-starting.md:
##########
@@ -32,16 +32,15 @@ under the License.
1. CPU：2C（最低）8C（推荐）
2. 内存：4G（最低）48G（推荐）
3. 硬盘：100G（最低）400G（推荐）
-4. 平台：MacOS（Intel）、LinuxOS、Windows虚拟机
+4. 平台：MacOS（Intel）、LinuxOS、Windows 虚拟机
5. 系统：CentOS（7.1及以上）、Ubuntu（16.04 及以上）
6. 软件：JDK（1.8及以上）、GCC（4.8.2 及以上）
## 单机部署
-**在创建之前，请准备好已完成编译的FE/BE文件，此教程不再赘述编译过程。**
+**在创建之前，请准备好已完成编译的 FE / BE 文件，此教程不再赘述编译过程。**
Review Comment:
has been restored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] emerkfu commented on a diff in pull request #11189: [doc] update get-starting.md
Posted by GitBox <gi...@apache.org>.
emerkfu commented on code in PR #11189:
URL: https://github.com/apache/doris/pull/11189#discussion_r930136513
##########
docs/en/docs/get-starting/get-starting.md:
##########
@@ -38,7 +38,7 @@ under the License.
## Stand-alone deployment
-**Before creating, please prepare the compiled FE/BE file, this tutorial will not repeat the compilation process.**
+**Before creating, please prepare the compiled FE / BE file, this tutorial will not repeat the compilation process.**
Review Comment:
has been restored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11189: [doc] update get-starting.md
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11189:
URL: https://github.com/apache/doris/pull/11189#issuecomment-1198032467
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hf200012 closed pull request #11189: [doc] update get-starting.md
Posted by GitBox <gi...@apache.org>.
hf200012 closed pull request #11189: [doc] update get-starting.md
URL: https://github.com/apache/doris/pull/11189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #11189: [doc] update get-starting.md
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #11189:
URL: https://github.com/apache/doris/pull/11189#issuecomment-1215021951
@emerkfu please rebase to resolve conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] emerkfu commented on a diff in pull request #11189: [doc] update get-starting.md
Posted by GitBox <gi...@apache.org>.
emerkfu commented on code in PR #11189:
URL: https://github.com/apache/doris/pull/11189#discussion_r930138938
##########
docs/zh-CN/docs/get-starting/get-starting.md:
##########
@@ -32,16 +32,15 @@ under the License.
1. CPU：2C（最低）8C（推荐）
2. 内存：4G（最低）48G（推荐）
3. 硬盘：100G（最低）400G（推荐）
-4. 平台：MacOS（Intel）、LinuxOS、Windows虚拟机
+4. 平台：MacOS（Intel）、LinuxOS、Windows 虚拟机
5. 系统：CentOS（7.1及以上）、Ubuntu（16.04 及以上）
6. 软件：JDK（1.8及以上）、GCC（4.8.2 及以上）
## 单机部署
-**在创建之前，请准备好已完成编译的FE/BE文件，此教程不再赘述编译过程。**
+**在创建之前，请准备好已完成编译的 FE / BE 文件，此教程不再赘述编译过程。**
-
-**该教程为单节点、1FE 和 1BE 的混布教程，只需要一个节点，便于快速体验 Doris。**
+**该教程为单节点、1 FE 和 1 BE 的混合部署教程，只需要一个节点，便于快速体验 Doris。**
Review Comment:
Deleted empty line have been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11189: [doc] update get-starting.md
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11189:
URL: https://github.com/apache/doris/pull/11189#issuecomment-1196260568
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org