You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/08/29 02:20:50 UTC
[GitHub] [james-project] chibenwa opened a new pull request, #1163: [BUILD] Reuse FakeSMTP container port 25
chibenwa opened a new pull request, #1163:
URL: https://github.com/apache/james-project/pull/1163
With this, I run mailet integration tests in 2 min locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a diff in pull request #1163: [BUILD] Reuse FakeSMTP container port 25
Posted by GitBox <gi...@apache.org>.
Arsnael commented on code in PR #1163:
URL: https://github.com/apache/james-project/pull/1163#discussion_r956855815
##########
server/testing/src/main/java/org/apache/james/utils/FakeSmtp.java:
##########
@@ -62,13 +61,30 @@ public static void clean(RequestSpecification requestSpecification) {
}
public static FakeSmtp withSmtpPort(Integer smtpPort) {
- DockerContainer container = fakeSmtpContainer()
- .withExposedPorts(smtpPort)
- .withCommands("node", "cli", "--listen", "80", "--smtp", smtpPort.toString());
+ DockerContainer container = reuseContainerIfPossible(smtpPort);
+
+ if (!container.isRunning()) {
+ container.start();
+ }
return new FakeSmtp(container);
}
+ private static DockerContainer reuseContainerIfPossible(Integer smtpPort) {
+ if (smtpPort == SMTP_PORT ) {
Review Comment:
whitespace here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1163: [BUILD] Reuse FakeSMTP container port 25
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #1163:
URL: https://github.com/apache/james-project/pull/1163#issuecomment-1231146630
## After
`04:53:43,943 [INFO] Apache James :: Server :: Mailet :: Integration Testing SUCCESS [03:27 min]`
## Before
`05:38:55,338 [INFO] Apache James :: Server :: Mailet :: Integration Testing SUCCESS [04:06 min]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1163: [BUILD] Reuse FakeSMTP container port 25
Posted by GitBox <gi...@apache.org>.
Arsnael commented on PR #1163:
URL: https://github.com/apache/james-project/pull/1163#issuecomment-1229693539
```
02:26:24,530 [INFO] There is 1 error reported by Checkstyle 8.29 with checkstyle.xml ruleset.
02:26:24,532 [ERROR] src/main/java/org/apache/james/utils/FakeSmtp.java:[74,35] (whitespace) ParenPad: ')' is preceded with whitespace.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #1163: [BUILD] Reuse FakeSMTP container port 25
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #1163:
URL: https://github.com/apache/james-project/pull/1163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org