You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/11 09:09:35 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #1509: [Enhancement] Use try-with-resources to manage the closure of resources
Alonexc opened a new issue, #1509:
URL: https://github.com/apache/incubator-eventmesh/issues/1509
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:org/apache/eventmesh/admin/rocketmq/handler/TopicsHandler.java line 102
This method allocates and uses an auto closeable resource. However, it manually closes the resource in a finally block. While this is correct management, it doesn't rely on the idiomatic way available to JDK 7 and above, allows for possible subtle problems, and complicates the reading of code by developers expecting the use of try-with-resources.
### Describe the solution you'd like
It is recommended to use try-with-resources to manage the closure of resources.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Shrikumar18 commented on issue #1509: [Enhancement] Use try-with-resources to manage the closure of resources
Posted by GitBox <gi...@apache.org>.
Shrikumar18 commented on issue #1509:
URL: https://github.com/apache/incubator-eventmesh/issues/1509#issuecomment-1279354155
Hi @xwm1992, I would like to work on it, kindly assign it to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #1509: [Enhancement] Use try-with-resources to manage the closure of resources
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #1509:
URL: https://github.com/apache/incubator-eventmesh/issues/1509#issuecomment-1279591000
sure
Shri kumar ***@***.***>于2022年10月15日 周六02:57写道：
> Hi @xwm1992 <https://github.com/xwm1992>, I would like to work on it,
> kindly assign it to me
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-eventmesh/issues/1509#issuecomment-1279354155>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGH3J5NUBYH46YDLQACZE4DWDGUINANCNFSM6AAAAAARCCFOBM>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mroccyen commented on issue #1509: [Enhancement] Use try-with-resources to manage the closure of resources
Posted by GitBox <gi...@apache.org>.
mroccyen commented on issue #1509:
URL: https://github.com/apache/incubator-eventmesh/issues/1509#issuecomment-1274478781
i will try my best to do it，please assign to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 closed issue #1509: [Enhancement] Use try-with-resources to manage the closure of resources
Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #1509: [Enhancement] Use try-with-resources to manage the closure of resources
URL: https://github.com/apache/incubator-eventmesh/issues/1509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on issue #1509: [Enhancement] Use try-with-resources to manage the closure of resources
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on issue #1509:
URL: https://github.com/apache/incubator-eventmesh/issues/1509#issuecomment-1274509059
> i will try my best to do it，please assign to me
sorry this issue is for the first time contributor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mroccyen commented on issue #1509: [Enhancement] Use try-with-resources to manage the closure of resources
Posted by GitBox <gi...@apache.org>.
mroccyen commented on issue #1509:
URL: https://github.com/apache/incubator-eventmesh/issues/1509#issuecomment-1274768241
> > i will try my best to do it，please assign to me
>
> sorry this issue is for the first time contributor.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org