[jira] Commented: (SHINDIG-805) Modularize contributors to gadgets.config.init and make them injectable

["Kevin Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660994#action_12660994 ] 

Kevin Brown commented on SHINDIG-805:
-------------------------------------

Any additional feedback on this one? This all looks good to me at this point.

> Modularize contributors to gadgets.config.init and make them injectable
> -----------------------------------------------------------------------
>
>                 Key: SHINDIG-805
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-805
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Common Components (Java), Gadget Rendering Server (Java)
>    Affects Versions: 1.0.x-incubating
>            Reporter: Henning Schmiedehausen
>         Attachments: SHINDIG-805, SHINDIG-805-2.patch
>
>
> In the RenderingContentRewriter, some content of the gadget.config.init is generated on the Java side and then injected to Javascript (i.e. it is not pulled from the features registered). This currently is the feature configuration for core.util (which has another bug, see SHINDIG-803) and the shindig.auth creation. Both of these are hard coded.
> In our use case, we need to contribute additional fields for platform specific configuration elements, which is best done on the Java core side. This patch pulls out the two pieces into ConfigContributors and makes these configureable and injectable through Guice, thus allowing integrators to add their own Contributors without having to patch the Shindig code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.