You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/06/14 23:43:46 UTC
[GitHub] [gobblin] jack-moseley opened a new pull request #3312: [GOBBLIN-1473] Fix ConcurrentModificationException when handling leadership change
jack-moseley opened a new pull request #3312:
URL: https://github.com/apache/gobblin/pull/3312
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1473
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Prevously, `ConcurrentModificationException` could happen when switching from active to inactive in the scheduler, because specs were removed from `scheduledFlowSpecs` while iterating through it. This fixes it in this scenario by not removing during iteration and just clearing the map at the end (since every entry should get removed anyway).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] jack-moseley commented on a change in pull request #3312: [GOBBLIN-1473] Fix ConcurrentModificationException when handling leadership change
Posted by GitBox <gi...@apache.org>.
jack-moseley commented on a change in pull request #3312:
URL: https://github.com/apache/gobblin/pull/3312#discussion_r652180811
##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -165,8 +165,9 @@ public void run() {
} else {
// Since we are going to change status to isActive=false, unschedule all flows
for (Spec spec : this.scheduledFlowSpecs.values()) {
- onDeleteSpec(spec.getUri(), spec.getVersion());
+ onDeleteSpec(spec.getUri(), spec.getVersion(), new Properties(), false);
Review comment:
Yeah that's true, that is much simpler. I was thinking that it may be expensive to clone all the specs, but we actually only need to clone the list, and it is okay if they are referencing the same Spec objects since we are not modifying those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] aplex commented on a change in pull request #3312: [GOBBLIN-1473] Fix ConcurrentModificationException when handling leadership change
Posted by GitBox <gi...@apache.org>.
aplex commented on a change in pull request #3312:
URL: https://github.com/apache/gobblin/pull/3312#discussion_r651958894
##########
File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -165,8 +165,9 @@ public void run() {
} else {
// Since we are going to change status to isActive=false, unschedule all flows
for (Spec spec : this.scheduledFlowSpecs.values()) {
- onDeleteSpec(spec.getUri(), spec.getVersion());
+ onDeleteSpec(spec.getUri(), spec.getVersion(), new Properties(), false);
Review comment:
Can we clone the values list instead? Then we will iterate on a copy of it that would not change when we remove entries from the map.
Overload with "removeFromMap" looks a bit strange, and future maintainers will have to spend some brain cycles to understand why it was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] autumnust merged pull request #3312: [GOBBLIN-1473] Fix ConcurrentModificationException when handling leadership change
Posted by GitBox <gi...@apache.org>.
autumnust merged pull request #3312:
URL: https://github.com/apache/gobblin/pull/3312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org