[jira] [Commented] (MYNEWT-858) Test package lflags ignored by `newt test`

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MYNEWT-858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349710#comment-16349710 ] 

ASF GitHub Bot commented on MYNEWT-858:
---------------------------------------

ccollins476ad opened a new pull request #133: MYNEWT-858 Collect all package lflags during link.
URL: https://github.com/apache/mynewt-newt/pull/133
 
 
   If you add the following to a test package:
   
   ```
   pkg.lflags:
       - "-foo"
   ```
   
   and then test the package with `newt test`, the flag does not get passed to gcc during linking.
   
   Newt currently only reads lflags from the following package types:
   * target
   * app
   * bsp
   * compiler
   
   Now, all packages' lflags are collected and specified during linking.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Test package lflags ignored by `newt test`
> ------------------------------------------
>
>                 Key: MYNEWT-858
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-858
>             Project: Mynewt
>          Issue Type: Bug
>      Security Level: Public(Viewable by anyone) 
>          Components: Newt
>            Reporter: Christopher Collins
>            Assignee: Sterling Hughes
>            Priority: Major
>             Fix For: v1_4_0_rel
>
>
> If you add the following to a test package:
> {noformat}
> pkg.lflags:
>     - "-foo"
> {noformat}
> and then test the package with `newt test`, the flag does not get passed to gcc during linking.
> Newt currently only reads lflags from the following package types:
> * target
> * app
> * bsp
> * compiler
> At the very least, the test package's lflags should be used when a unit test is linked via {{newt test}}.  Alternatively, it may make more sense to gather the lflags from all constituent packages during the link phase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)