[jira] [Commented] (HIVE-7622) Semi-automated cleanup of code

["Ashutosh Chauhan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116965#comment-14116965 ] 

Ashutosh Chauhan commented on HIVE-7622:
----------------------------------------

For this to have a chance of getting committed, I would suggest to split this patch on either of following lines:
* Do cleanup per module (ql, metastore, etc.)
* Do cleanup for a kind of fixup (removing redundant modifiers, converting all tabs to spaces, etc.)

I think second option will be more convenient for review, but if you choose first, thats fine too.

> Semi-automated cleanup of code
> ------------------------------
>
>                 Key: HIVE-7622
>                 URL: https://issues.apache.org/jira/browse/HIVE-7622
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-7622.1-noprefix.patch
>
>
> This patch fixes the following issues across the whole Hive codebase. I realize it's huge but these are all things that slipped through past reviews and pop up in Checkstyle, SonarQube, IDEs, etc.:
> * Remove redundant modifiers (e.g. {{public}} modifiers in interfaces)
> * Converts all tabs to spaces
> * Removes all redundant semicolons
> * Minor issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)