You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "machov (via GitHub)" <gi...@apache.org> on 2026/02/23 15:04:00 UTC
[PR] fix(tests): add missing main block to test_session.py [spark]
machov opened a new pull request, #54426:
URL: https://github.com/apache/spark/pull/54426
Fixes #54405
The `test_session.py` file was missing the `if __name__ == '__main__'` block that allows it to be executed directly and included in CI runs. This follows the pattern established in other test files throughout the codebase.
This simple addition resolves the issue where these tests were not being executed in CI, ensuring better test coverage going forward.
**Changes:**
- Added standard main block to `python/pyspark/sql/tests/connect/test_session.py`
- Follows the same pattern used in other test files (imports `main` from `pyspark.testing`)
**Testing:**
The file can now be executed directly with `python test_session.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] fix(tests): add missing main block to test_session.py [spark]
Posted by "machov (via GitHub)" <gi...@apache.org>.
machov closed pull request #54426: fix(tests): add missing main block to test_session.py
URL: https://github.com/apache/spark/pull/54426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] fix(tests): add missing main block to test_session.py [spark]
Posted by "gaogaotiantian (via GitHub)" <gi...@apache.org>.
gaogaotiantian commented on PR #54426:
URL: https://github.com/apache/spark/pull/54426#issuecomment-3947028382
The problem is not that this test does not run - it's that the test fails. I skipped working on this because I'm not sure what the original author tries to validate. I already reached out to the original author of the test and hopefully he can fix the test itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org