You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2026/10/11 07:28:49 UTC

[GH] (shardingsphere/fix-issue-39765-otel-span-scope): Workflow run "CI" failed!

The GitHub Actions job "CI" on shardingsphere.git/fix-issue-39765-otel-span-scope has failed.
Run started by GitHub user HhH666-ux (triggered by HhH666-ux).

Head commit for run:
0107509ced6c1d548f547bc55384360f4d4fecbd / 电大老baby <32...@qq.com>
End spans only in afterMethod to keep nested invocations isolated

The agent executor calls onThrowing before the finally block calls
afterMethod, so ending the span in both hooks made a failing nested
invocation pop twice: its own span and the still-running outer span.

Wrap the started span in a PendingSpan holding the throwable recorded by
onThrowing; afterMethod is now the single exit that pops the pending span,
applies OK/ERROR status and ends it. onThrowing only records.

Add assertNestedFailureDoesNotEndOuterSpan covering the full nested
lifecycle, and align the tests with project conventions (JUnit assertNull,
actual-prefixed variables, Collection declarations, import order).

Report URL: https://github.com/apache/shardingsphere/actions/runs/38120930500

With regards,
GitHub Actions via GitBox