You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by "sunnysabor (via GitHub)" <gi...@apache.org> on 2026/10/02 02:12:04 UTC
[PR] [type:build] add root Maven build baseline [shenyu-plugin-store]
sunnysabor opened a new pull request, #5:
URL: https://github.com/apache/shenyu-plugin-store/pull/5
## Summary
Make the plugin-store reactor buildable and testable from a clean checkout with the Maven Wrapper.
- Add Maven Wrapper scripts and wrapper configuration.
- Fix the nested proxy aggregator's parent resolution and declare the released ShenYu 2.7.0 BOM/API dependencies used by the plugins.
- Align compilation with the repository's Java 17 baseline, wire Checkstyle and Apache RAT into the root lifecycle, and make the starter and proxy modules part of the root reactor.
- Restore TARS unit-test execution and repair Motan references to API classes no longer present in the released ShenYu API.
This addresses the repository-build portion of [apache/shenyu#7294](https://github.com/apache/shenyu/issues/7294). The issue's CI, E2E, compatibility documentation, and release-governance work remain separate follow-up items.
## Verification
- `./mvnw -B -ntp clean verify` — passed for all 8 reactor modules on JDK 17; 45 tests passed, with Checkstyle and RAT passing.
- `git diff --cached --check` — passed.
## Checklist
- [x] Added or enabled unit tests for the affected modules.
- [x] Ran the full root build, unit tests, Checkstyle, and RAT.
- [x] No Markdown files are included in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:build] add root Maven build baseline [shenyu-plugin-store]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 merged PR #5:
URL: https://github.com/apache/shenyu-plugin-store/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [type:build] add root Maven build baseline [shenyu-plugin-store]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on code in PR #5:
URL: https://github.com/apache/shenyu-plugin-store/pull/5#discussion_r4216790197
##########
pom.xml:
##########
@@ -64,6 +64,9 @@
<properties>
<java.version>17</java.version>
+ <shenyu.version>2.7.0</shenyu.version>
Review Comment:
[NIT] shenyu.version is pinned to 2.7.0 while the store repo itself is 2.7.1-SNAPSHOT. Confirm 2.7.0 is the intended shenyu compatibility target (the store plugins compile against the released shenyu 2.7.0 BOM). If store is meant to track shenyu 2.7.1, bump this to 2.7.1.
##########
shenyu-spring-boot-starter-plugin/pom.xml:
##########
@@ -30,5 +30,25 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
+ <modules>
+ <module>shenyu-spring-boot-starter-plugin-motan</module>
+ <module>shenyu-spring-boot-starter-plugin-tars</module>
+ </modules>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-autoconfigure</artifactId>
Review Comment:
[NIT] spring-boot-autoconfigure is declared as a compile dependency on the aggregator (lines 37-52), so it is inherited by the motan/tars starter submodules. It works because the shenyu 2.7.0 BOM imports spring-boot-dependencies (version is managed), but these starter-specific deps read cleaner if declared in each individual starter module rather than the aggregator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org