You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2015/06/24 23:49:39 UTC
Review Request 35842: Use java.util.Optional and streams in
LockManager
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
Description
-------
Use java.util.Optional and streams in Lock*.
Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API
Diffs
-----
src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb
src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca
src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386
src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b
src/main/java/org/apache/aurora/util/GuavaCollectors.java PRE-CREATION
src/main/resources/apache/aurora/client/cli/.auroraversion 5ea35de7ada4edef3189e0b01b322d50e8f8a638
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a
src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965
src/test/java/org/apache/aurora/util/GuavaCollectorsTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35842/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney
Re: Review Request 35842: Use java.util.Optional and streams in
LockManager
Posted by Kevin Sweeney <ke...@apache.org>.
> On June 24, 2015, 3:15 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/util/GuavaCollectors.java, line 36
> > <https://reviews.apache.org/r/35842/diff/2/?file=991612#file991612line36>
> >
> > I think this collector needs to be given the unordered characteristic because it is building a set where the order will be lost: https://docs.oracle.com/javase/8/docs/api/java/util/stream/Collector.Characteristics.html#UNORDERED
Added.
> On June 24, 2015, 3:15 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 263
> > <https://reviews.apache.org/r/35842/diff/2/?file=991611#file991611line263>
> >
> > I think we should be importing java.util.Optional at the top of the file and inlining use of com.google.common.base.Optional as necessary.
> >
> > Now that we are on JDK 8 we should be prefering use of java.util.Optional. If that change is very noisey, can you check how difficult it would be to remove guava's Optional in these files?
This is the lower blast-radius change - this file is almost 1400 lines, and many of the APIs it calls are still written in terms of guava Optional.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/#review89257
-----------------------------------------------------------
On June 24, 2015, 2:52 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35842/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 2:52 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use java.util.Optional and streams in Lock*.
>
> Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386
> src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b
> src/main/java/org/apache/aurora/util/GuavaCollectors.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a
> src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965
> src/test/java/org/apache/aurora/util/GuavaCollectorsTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35842/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 35842: Use java.util.Optional and streams in
LockManager
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/#review89257
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (line 257)
<https://reviews.apache.org/r/35842/#comment141851>
I think we should be importing java.util.Optional at the top of the file and inlining use of com.google.common.base.Optional as necessary.
Now that we are on JDK 8 we should be prefering use of java.util.Optional. If that change is very noisey, can you check how difficult it would be to remove guava's Optional in these files?
src/main/java/org/apache/aurora/util/GuavaCollectors.java (line 36)
<https://reviews.apache.org/r/35842/#comment141853>
I think this collector needs to be given the unordered characteristic because it is building a set where the order will be lost: https://docs.oracle.com/javase/8/docs/api/java/util/stream/Collector.Characteristics.html#UNORDERED
- Zameer Manji
On June 24, 2015, 2:52 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35842/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 2:52 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use java.util.Optional and streams in Lock*.
>
> Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386
> src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b
> src/main/java/org/apache/aurora/util/GuavaCollectors.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a
> src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965
> src/test/java/org/apache/aurora/util/GuavaCollectorsTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35842/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 35842: Use java.util.Optional and streams in
LockManager
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/#review89255
-----------------------------------------------------------
Ship it!
Master (d28bd4f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 24, 2015, 9:52 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35842/
> -----------------------------------------------------------
>
> (Updated June 24, 2015, 9:52 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use java.util.Optional and streams in Lock*.
>
> Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386
> src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b
> src/main/java/org/apache/aurora/util/GuavaCollectors.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a
> src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965
> src/test/java/org/apache/aurora/util/GuavaCollectorsTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35842/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 35842: Use java.util.Optional and streams in
LockManager
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/#review89407
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On June 25, 2015, 11:32 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35842/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 11:32 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use java.util.Optional and streams in Lock*.
>
> Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java 22104e6d005ae6706a06a21ffe4c730b14ecfe53
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386
> src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b
> src/test/java/org/apache/aurora/GuavaUtilsTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a
> src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965
>
> Diff: https://reviews.apache.org/r/35842/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 35842: Use java.util.Optional and streams in
LockManager
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/#review89405
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On June 25, 2015, 6:32 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35842/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 6:32 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use java.util.Optional and streams in Lock*.
>
> Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java 22104e6d005ae6706a06a21ffe4c730b14ecfe53
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386
> src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b
> src/test/java/org/apache/aurora/GuavaUtilsTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a
> src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965
>
> Diff: https://reviews.apache.org/r/35842/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 35842: Use java.util.Optional and streams in
LockManager
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/#review89406
-----------------------------------------------------------
Ship it!
Master (d28bd4f) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 25, 2015, 6:32 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35842/
> -----------------------------------------------------------
>
> (Updated June 25, 2015, 6:32 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use java.util.Optional and streams in Lock*.
>
> Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java 22104e6d005ae6706a06a21ffe4c730b14ecfe53
> src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761
> src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca
> src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386
> src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b
> src/test/java/org/apache/aurora/GuavaUtilsTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a
> src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965
>
> Diff: https://reviews.apache.org/r/35842/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 35842: Use java.util.Optional and streams in
LockManager
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/
-----------------------------------------------------------
(Updated June 25, 2015, 11:32 a.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Move GuavaCollectors to existing GuiceUtils class.
Repository: aurora
Description
-------
Use java.util.Optional and streams in Lock*.
Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API
Diffs (updated)
-----
src/main/java/org/apache/aurora/GuavaUtils.java 22104e6d005ae6706a06a21ffe4c730b14ecfe53
src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb
src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca
src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386
src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b
src/test/java/org/apache/aurora/GuavaUtilsTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a
src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965
Diff: https://reviews.apache.org/r/35842/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney
Re: Review Request 35842: Use java.util.Optional and streams in
LockManager
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/
-----------------------------------------------------------
(Updated June 25, 2015, 11:12 a.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Add UNORDERED characteristic.
Repository: aurora
Description
-------
Use java.util.Optional and streams in Lock*.
Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb
src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca
src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386
src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b
src/main/java/org/apache/aurora/util/GuavaCollectors.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a
src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965
src/test/java/org/apache/aurora/util/GuavaCollectorsTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35842/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney
Re: Review Request 35842: Use java.util.Optional and streams in
LockManager
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/
-----------------------------------------------------------
(Updated June 24, 2015, 2:52 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Revert .auroraversion change that snuck in.
Repository: aurora
Description
-------
Use java.util.Optional and streams in Lock*.
Taking advantage of some Java 8 features along the way, and introduced GuavaCollectors.toImmutableSet for compatibility with the streams API
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/state/LockManager.java e8303f914466ebe93518ec2970e1173dc39d9adb
src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 6aa281cb7b07e3e82c578c553eee8c7066cf2761
src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 2be3eb0e9405e3d34533520095423429fe00a2ca
src/main/java/org/apache/aurora/scheduler/storage/LockStore.java 596a3787369616d30a2763a37bcb7b7cc39ad386
src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 335d7a95e797fe940e71b10da44cbd97edea69ac
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0670b2b4c3817becefb38f0294f111768386817b
src/main/java/org/apache/aurora/util/GuavaCollectors.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 9c9cf1b45506a2c0e1a15e3e92f1bee83778a12a
src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java ecbe1dd1eb1f0de07bea490b076c7a920f08bccb
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 38ef412a6d29dfef7b305e00cf44522818303965
src/test/java/org/apache/aurora/util/GuavaCollectorsTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35842/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney