You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2013/06/26 21:04:15 UTC
Review Request 12116: PROTON-C: allow unspecified target address if target
is dynamic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12116/
-----------------------------------------------------------
Review request for qpid, Gordon Sim, Rafael Schloming, and Ted Ross.
Bugs: proton-227
https://issues.apache.org/jira/browse/proton-227
Repository: qpid
Description
-------
Gordon's patch to allow the creation of a terminus (source/target) without an address when the dynamic flag is true.
Diffs
-----
/proton/trunk/proton-c/src/engine/engine.c 1496140
/proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1496140
/proton/trunk/tests/python/proton_tests/engine.py 1496140
Diff: https://reviews.apache.org/r/12116/diff/
Testing
-------
New testcase added, verified for both proton-c and proton-j.
Thanks,
Kenneth Giusti
Re: Review Request 12116: PROTON-C: allow unspecified target address if
target is dynamic
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12116/#review22464
-----------------------------------------------------------
Ship it!
Note that the correct issue is Proton-277.
- Gordon Sim
On June 26, 2013, 7:04 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12116/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 7:04 p.m.)
>
>
> Review request for qpid, Gordon Sim, Rafael Schloming, and Ted Ross.
>
>
> Bugs: proton-227
> https://issues.apache.org/jira/browse/proton-227
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Gordon's patch to allow the creation of a terminus (source/target) without an address when the dynamic flag is true.
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/src/engine/engine.c 1496140
> /proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1496140
> /proton/trunk/tests/python/proton_tests/engine.py 1496140
>
> Diff: https://reviews.apache.org/r/12116/diff/
>
>
> Testing
> -------
>
> New testcase added, verified for both proton-c and proton-j.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request 12116: PROTON-C: allow unspecified target address if
target is dynamic
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12116/
-----------------------------------------------------------
(Updated June 27, 2013, 1:05 p.m.)
Review request for qpid, Gordon Sim, Rafael Schloming, and Ted Ross.
Changes
-------
Fixed jira reference (thanks Gordon!)
Bugs: proton-277
https://issues.apache.org/jira/browse/proton-277
Repository: qpid
Description
-------
Gordon's patch to allow the creation of a terminus (source/target) without an address when the dynamic flag is true.
Diffs
-----
/proton/trunk/proton-c/src/engine/engine.c 1496140
/proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1496140
/proton/trunk/tests/python/proton_tests/engine.py 1496140
Diff: https://reviews.apache.org/r/12116/diff/
Testing
-------
New testcase added, verified for both proton-c and proton-j.
Thanks,
Kenneth Giusti
Re: Review Request 12116: PROTON-C: allow unspecified target address if
target is dynamic
Posted by Rafael Schloming <rh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12116/#review22466
-----------------------------------------------------------
Ship it!
Ship It!
- Rafael Schloming
On June 26, 2013, 7:04 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12116/
> -----------------------------------------------------------
>
> (Updated June 26, 2013, 7:04 p.m.)
>
>
> Review request for qpid, Gordon Sim, Rafael Schloming, and Ted Ross.
>
>
> Bugs: proton-227
> https://issues.apache.org/jira/browse/proton-227
>
>
> Repository: qpid
>
>
> Description
> -------
>
> Gordon's patch to allow the creation of a terminus (source/target) without an address when the dynamic flag is true.
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/src/engine/engine.c 1496140
> /proton/trunk/proton-j/proton-api/src/main/resources/proton.py 1496140
> /proton/trunk/tests/python/proton_tests/engine.py 1496140
>
> Diff: https://reviews.apache.org/r/12116/diff/
>
>
> Testing
> -------
>
> New testcase added, verified for both proton-c and proton-j.
>
>
> Thanks,
>
> Kenneth Giusti
>
>