You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "muralibasani (via GitHub)" <gi...@apache.org> on 2026/09/11 17:40:23 UTC

[PR] KAFKA-21073: Enable SASL for the native image docker examples and sanity test [kafka]

muralibasani opened a new pull request, #23437:
URL: https://github.com/apache/kafka/pull/23437

   Ref : https://issues.apache.org/jira/browse/KAFKA-21073
   
   - Remove the three stale "SASL not supported on native" notes from docker/examples/README.md and add the apache/kafka-native run command to each SASL example, for parity with the other examples.
   - Remove the MODE == "jvm" guard in docker_sanity_test.py so the SASL flow runs for the native image as well as the JVM image.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-21073: Enable SASL for the native image docker examples and sanity test [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23437:
URL: https://github.com/apache/kafka/pull/23437#discussion_r3996496386


##########
docker/test/docker_sanity_test.py:
##########
@@ -195,13 +195,11 @@ def execute(self):
         except Exception as e:
             print(constants.FILE_INPUT_ERROR_PREFIX, str(e))
             total_errors.append(str(e))
-        # SASL is not supported on native image due to missing reflection config (KAFKA-19584)
-        if self.MODE == "jvm":

Review Comment:
   It seems the `MODE` is useless :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-21073: Enable SASL for the native image docker examples and sanity test [kafka]

Posted by "muralibasani (via GitHub)" <gi...@apache.org>.
muralibasani commented on code in PR #23437:
URL: https://github.com/apache/kafka/pull/23437#discussion_r3996809492


##########
docker/test/docker_sanity_test.py:
##########
@@ -195,13 +195,11 @@ def execute(self):
         except Exception as e:
             print(constants.FILE_INPUT_ERROR_PREFIX, str(e))
             total_errors.append(str(e))
-        # SASL is not supported on native image due to missing reflection config (KAFKA-19584)
-        if self.MODE == "jvm":

Review Comment:
   Ah yes, removed it. 



##########
docker/test/docker_sanity_test.py:
##########
@@ -195,13 +195,11 @@ def execute(self):
         except Exception as e:
             print(constants.FILE_INPUT_ERROR_PREFIX, str(e))
             total_errors.append(str(e))
-        # SASL is not supported on native image due to missing reflection config (KAFKA-19584)
-        if self.MODE == "jvm":

Review Comment:
   Thank you for the review.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-21073: Enable SASL for the native image docker examples and sanity test [kafka]

Posted by "muralibasani (via GitHub)" <gi...@apache.org>.
muralibasani commented on PR #23437:
URL: https://github.com/apache/kafka/pull/23437#issuecomment-5639267117

   Tests locally
   
   ```
   % python3 -m pip install -r docker/requirements.txt
   
   % python3 docker/docker_build_test.py kafka-native-sanity -tag test -type native \
       --kafka-archive "$(pwd)/core/build/distributions/kafka_2.13-4.5.0-SNAPSHOT.tgz" -t
   
   Running SASL Flow Tests
   Created topic test-topic-sasl.
   The consumer rebalance protocol (KIP-848) is production-ready! Set group.protocol=consumer to try it out. See https://kafka.apache.org/documentation/#consumer_rebalance_protocol
   Processed a total of 1 messages
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-21073: Enable SASL for the native image docker examples and sanity test [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #23437:
URL: https://github.com/apache/kafka/pull/23437


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org