You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/01/17 21:25:07 UTC

[GitHub] [tvm] junrushao1994 opened a new issue #9952: [CI Problem] Flaky Test: `tests/python/unittest/test_meta_schedule_schedule_rule_auto_inline.py::test_inline_into_cache`

junrushao1994 opened a new issue #9952:
URL: https://github.com/apache/tvm/issues/9952


   ### Branch/PR Failing
   
   Looks like [this PR](https://github.com/apache/tvm/pull/9943) introduced a flaky test. Likely it's due to some concurrent merge.
   
   ### Jenkins Link
   
   https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/2417/pipeline/
   
   ### Flakiness
   
   Yes.
   
   CC: @MasterJH5574 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] wrongtest commented on issue #9952: [CI Problem] Flaky Test: `tests/python/unittest/test_meta_schedule_schedule_rule_auto_inline.py::test_inline_into_cache`

Posted by GitBox <gi...@apache.org>.
wrongtest commented on issue #9952:
URL: https://github.com/apache/tvm/issues/9952#issuecomment-1015384470


   cc @junrushao1994 @Hzfengsy  
   
   The fix trial is here https://github.com/apache/tvm/pull/9958
   
   I am sorry for introducing this issue. I believe it is introduced by https://github.com/apache/tvm/pull/9372, but detected until subsequent change https://github.com/apache/tvm/pull/9880 which touch more testcases.
   
   Developers have already pointed out that with equations like `xx + rx >= 1`, the `SolveInequalitiesToRange` create undetermined results for the failed case. After a look through I found that actually the result of ` SolveInequalitiesToRange` depend on the to-solve variables order we pass in. However, in the region analysis context, I used an unordered_dict with ObjectPtrHash to record the variables. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] junrushao1994 closed issue #9952: [CI Problem] Flaky Test: `tests/python/unittest/test_meta_schedule_schedule_rule_auto_inline.py::test_inline_into_cache`

Posted by GitBox <gi...@apache.org>.
junrushao1994 closed issue #9952:
URL: https://github.com/apache/tvm/issues/9952


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] junrushao1994 commented on issue #9952: [CI Problem] Flaky Test: `tests/python/unittest/test_meta_schedule_schedule_rule_auto_inline.py::test_inline_into_cache`

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on issue #9952:
URL: https://github.com/apache/tvm/issues/9952#issuecomment-1015119442


   CC @wrongtest @Hzfengsy
   
   It looks like some randomness was introduced recently in `GetBlockReadWriteRegion`, possibly in [this commit](https://github.com/apache/tvm/commit/6f6fc68f5a028a92607b2907b9e4144543686639), but this particular robustness issue wasn't revealed until @MasterJH5574's PR:
   
   ![image](https://user-images.githubusercontent.com/22515877/149885366-a3b1d582-dd92-4984-9f59-82978636d62a.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] wrongtest edited a comment on issue #9952: [CI Problem] Flaky Test: `tests/python/unittest/test_meta_schedule_schedule_rule_auto_inline.py::test_inline_into_cache`

Posted by GitBox <gi...@apache.org>.
wrongtest edited a comment on issue #9952:
URL: https://github.com/apache/tvm/issues/9952#issuecomment-1015384470


   cc @junrushao1994 @Hzfengsy  
   
   The fix trial is here https://github.com/apache/tvm/pull/9958
   
   I am sorry for introducing this issue. I believe it is introduced by https://github.com/apache/tvm/pull/9372, but detected until subsequent change https://github.com/apache/tvm/pull/9880 which touch more testcases.
   
   Developers have already pointed out that with equations like `xx + rx >= 1`, the `SolveInequalitiesToRange` create undetermined results for the failed case. After a look through I found that actually the result of ` SolveInequalitiesToRange` depend on the to-solve variables order we pass in. However, in the region analysis context, I used an unordered_map with ObjectPtrHash to record the variables. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] junrushao1994 commented on issue #9952: [CI Problem] Flaky Test: `tests/python/unittest/test_meta_schedule_schedule_rule_auto_inline.py::test_inline_into_cache`

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on issue #9952:
URL: https://github.com/apache/tvm/issues/9952#issuecomment-1015503832


   Thanks for acting quickly on this issue @MasterJH5574 @wrongtest! I tried myself last night but failed to find the root reason. Thank you for finding this out!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org