You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/02/25 17:57:14 UTC

Review Request 18468: Start Services failed on Save and Apply Configuration step of Enable Security Wizard

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18468/
-----------------------------------------------------------

Review request for Ambari and Eugene Chekanskiy.


Bugs: AMBARI-4823
    https://issues.apache.org/jira/browse/AMBARI-4823


Repository: ambari


Description
-------

Start Services failed on Save and Apply Configuration step of Enable Security Wizard


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 4ad49dd 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py 7ec3135 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py 9d193cf 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_snamenode.py a943455 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7824744 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/utils.py a67d3b2 
  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py c6a560e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 185cca7 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py 023b653 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 0dad995 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_snamenode.py a943455 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py f2134d5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py f5f7a1f 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py aafdeee 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py c6a560e 
  ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py 6894a78 
  ambari-server/src/test/python/stacks/1.3.2/HDFS/test_namenode.py 0bed3d6 
  ambari-server/src/test/python/stacks/1.3.2/HDFS/test_snamenode.py 9436264 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 894631f 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py f453a6a 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py a91d3f9 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 7693d3f 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py b258c5d 

Diff: https://reviews.apache.org/r/18468/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 18468: Start Services failed on Save and Apply Configuration step of Enable Security Wizard

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On Feb. 25, 2014, 5:02 p.m., Eugene Chekanskiy wrote:
> > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/utils.py, line 49
> > <https://reviews.apache.org/r/18468/diff/1/?file=503379#file503379line49>
> >
> >     Only datanode need to be started under root in secure mode to bind ports under 1024.

this is fixed line above actually.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18468/#review35411
-----------------------------------------------------------


On Feb. 25, 2014, 4:57 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18468/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 4:57 p.m.)
> 
> 
> Review request for Ambari and Eugene Chekanskiy.
> 
> 
> Bugs: AMBARI-4823
>     https://issues.apache.org/jira/browse/AMBARI-4823
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Start Services failed on Save and Apply Configuration step of Enable Security Wizard
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 4ad49dd 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py 7ec3135 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py 9d193cf 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_snamenode.py a943455 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7824744 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/utils.py a67d3b2 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py c6a560e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 185cca7 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py 023b653 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 0dad995 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_snamenode.py a943455 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py f2134d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py f5f7a1f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py aafdeee 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py c6a560e 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py 6894a78 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_namenode.py 0bed3d6 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_snamenode.py 9436264 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 894631f 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py f453a6a 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py a91d3f9 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 7693d3f 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py b258c5d 
> 
> Diff: https://reviews.apache.org/r/18468/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 18468: Start Services failed on Save and Apply Configuration step of Enable Security Wizard

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.

> On Feb. 25, 2014, 5:02 p.m., Eugene Chekanskiy wrote:
> > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/utils.py, line 49
> > <https://reviews.apache.org/r/18468/diff/1/?file=503379#file503379line49>
> >
> >     Only datanode need to be started under root in secure mode to bind ports under 1024.
> 
> Andrew Onischuk wrote:
>     this is fixed line above actually.

all ok, i didn't noticed moved condition.


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18468/#review35411
-----------------------------------------------------------


On Feb. 25, 2014, 4:57 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18468/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 4:57 p.m.)
> 
> 
> Review request for Ambari and Eugene Chekanskiy.
> 
> 
> Bugs: AMBARI-4823
>     https://issues.apache.org/jira/browse/AMBARI-4823
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Start Services failed on Save and Apply Configuration step of Enable Security Wizard
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 4ad49dd 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py 7ec3135 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py 9d193cf 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_snamenode.py a943455 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7824744 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/utils.py a67d3b2 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py c6a560e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 185cca7 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py 023b653 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 0dad995 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_snamenode.py a943455 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py f2134d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py f5f7a1f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py aafdeee 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py c6a560e 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py 6894a78 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_namenode.py 0bed3d6 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_snamenode.py 9436264 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 894631f 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py f453a6a 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py a91d3f9 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 7693d3f 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py b258c5d 
> 
> Diff: https://reviews.apache.org/r/18468/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 18468: Start Services failed on Save and Apply Configuration step of Enable Security Wizard

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18468/#review35411
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/utils.py
<https://reviews.apache.org/r/18468/#comment65892>

    Only datanode need to be started under root in secure mode to bind ports under 1024.


- Eugene Chekanskiy


On Feb. 25, 2014, 4:57 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18468/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 4:57 p.m.)
> 
> 
> Review request for Ambari and Eugene Chekanskiy.
> 
> 
> Bugs: AMBARI-4823
>     https://issues.apache.org/jira/browse/AMBARI-4823
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Start Services failed on Save and Apply Configuration step of Enable Security Wizard
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 4ad49dd 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py 7ec3135 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py 9d193cf 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_snamenode.py a943455 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7824744 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/utils.py a67d3b2 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py c6a560e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 185cca7 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py 023b653 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 0dad995 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_snamenode.py a943455 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py f2134d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py f5f7a1f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py aafdeee 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py c6a560e 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py 6894a78 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_namenode.py 0bed3d6 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_snamenode.py 9436264 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 894631f 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py f453a6a 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py a91d3f9 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 7693d3f 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py b258c5d 
> 
> Diff: https://reviews.apache.org/r/18468/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 18468: Start Services failed on Save and Apply Configuration step of Enable Security Wizard

Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18468/#review35415
-----------------------------------------------------------

Ship it!


Ship It!

- Eugene Chekanskiy


On Feb. 25, 2014, 4:57 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18468/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2014, 4:57 p.m.)
> 
> 
> Review request for Ambari and Eugene Chekanskiy.
> 
> 
> Bugs: AMBARI-4823
>     https://issues.apache.org/jira/browse/AMBARI-4823
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Start Services failed on Save and Apply Configuration step of Enable Security Wizard
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-START/scripts/params.py 4ad49dd 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_datanode.py 7ec3135 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_namenode.py 9d193cf 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/hdfs_snamenode.py a943455 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py 7824744 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/utils.py a67d3b2 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/package/scripts/params.py c6a560e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py 185cca7 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_datanode.py 023b653 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py 0dad995 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_snamenode.py a943455 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py f2134d5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py f5f7a1f 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py aafdeee 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py c6a560e 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_datanode.py 6894a78 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_namenode.py 0bed3d6 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_snamenode.py 9436264 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 894631f 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py f453a6a 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py a91d3f9 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 7693d3f 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py b258c5d 
> 
> Diff: https://reviews.apache.org/r/18468/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>