You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "angoenka (GitHub)" <gi...@apache.org> on 2018/08/23 07:40:17 UTC

[GitHub] [beam] angoenka opened pull request #6267: [BEAM-5190] Fixing Python SDK thread count for Portable Runners

Portable pipeline options have a different structure than the legacy runners. Correctly parsing the pipeline options and using it to get the worker_threads

------------------------

Follow this checklist to help us incorporate your contribution quickly and easily:

 - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
 - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.

Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------

Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_
 Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---






[ Full content available at: https://github.com/apache/beam/pull/6267 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [beam] angoenka commented on issue #6267: [BEAM-5190] Fixing Python SDK thread count for Portable Runners

Posted by "angoenka (GitHub)" <gi...@apache.org>.
Done!

[ Full content available at: https://github.com/apache/beam/pull/6267 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [beam] pabloem closed pull request #6267: [BEAM-5190] Fixing Python SDK thread count for Portable Runners

Posted by "pabloem (GitHub)" <gi...@apache.org>.
[ pull request closed by pabloem ]

[ Full content available at: https://github.com/apache/beam/pull/6267 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [beam] angoenka commented on issue #6267: [BEAM-5190] Fixing Python SDK thread count for Portable Runners

Posted by "angoenka (GitHub)" <gi...@apache.org>.
This PR is based on top of https://github.com/apache/beam/pull/6262

R: @tweise @aaltay 

[ Full content available at: https://github.com/apache/beam/pull/6267 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [beam] pabloem commented on issue #6267: [BEAM-5190] Fixing Python SDK thread count for Portable Runners

Posted by "pabloem (GitHub)" <gi...@apache.org>.
LGTM!

[ Full content available at: https://github.com/apache/beam/pull/6267 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org

[GitHub] [beam] tweise commented on issue #6267: [BEAM-5190] Fixing Python SDK thread count for Portable Runners

Posted by "tweise (GitHub)" <gi...@apache.org>.
@angoenka squash/rebase?

[ Full content available at: https://github.com/apache/beam/pull/6267 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org