You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "rohangarg (via GitHub)" <gi...@apache.org> on 2023/02/27 08:46:31 UTC
[GitHub] [druid] rohangarg opened a new pull request, #13853: Fix durable storage cleanup
rohangarg opened a new pull request, #13853:
URL: https://github.com/apache/druid/pull/13853
While testing durable shuffle storage, intermittently rate limiting on DELETE object operations is observed in the logs. Further, sometimes there are failures in the job due to us trying to open streams on s3 objects which have been already deleted.
A couple of changes are done to fix these problems :
1. Do the worker level DELETE op only once which cleans up all the partitions for a stage for that worker
2. When the S3 input stream (Sequence stream of chunks) is closed, avoid the default behavior of the `SequenceInputStream` to open/close all the chunks. Since our chunking is lazy, we can just close the current chunk stream and then exit.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] cryptoe merged pull request #13853: Fix durable storage cleanup
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #13853:
URL: https://github.com/apache/druid/pull/13853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org