You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/21 04:42:35 UTC

[GitHub] [apisix] moonming opened a new pull request #2481: makefile: add release-src in makefile.

moonming opened a new pull request #2481:
URL: https://github.com/apache/apisix/pull/2481


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   Using this script we can generate the release package more quickly
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on a change in pull request #2481: makefile: add release-src in makefile.

Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #2481:
URL: https://github.com/apache/apisix/pull/2481#discussion_r509004806



##########
File path: Makefile
##########
@@ -190,3 +194,29 @@ ifeq ("$(wildcard .travis/openwhisk-utilities/scancode/scanCode.py)", "")
 endif
 	.travis/openwhisk-utilities/scancode/scanCode.py --config .travis/ASF-Release.cfg ./
 
+release-src:

Review comment:
       It is ony for Apache release manager




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2481: makefile: add release-src in makefile.

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2481:
URL: https://github.com/apache/apisix/pull/2481#discussion_r509002692



##########
File path: Makefile
##########
@@ -190,3 +194,29 @@ ifeq ("$(wildcard .travis/openwhisk-utilities/scancode/scanCode.py)", "")
 endif
 	.travis/openwhisk-utilities/scancode/scanCode.py --config .travis/ASF-Release.cfg ./
 
+release-src:

Review comment:
       add some comment in this way: https://github.com/apache/apisix/pull/2481/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R188
   
   Then we can get help information through the command `make help`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming merged pull request #2481: makefile: add release-src in makefile.

Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2481:
URL: https://github.com/apache/apisix/pull/2481


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2481: makefile: add release-src in makefile.

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2481:
URL: https://github.com/apache/apisix/pull/2481#discussion_r509013222



##########
File path: Makefile
##########
@@ -24,6 +24,10 @@ UNAME ?= $(shell uname)
 OR_EXEC ?= $(shell which openresty)
 LUAROCKS_VER ?= $(shell luarocks --version | grep -E -o  "luarocks [0-9]+.")
 
+SHELL := /bin/bash -o pipefail

Review comment:
       seems that this line is not necessary. can we delete it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org