[flink] branch master updated: [FLINK-12253][table-common] Add a DOUBLE type

[tw...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

twalthr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/master by this push:
     new 537cd10  [FLINK-12253][table-common] Add a DOUBLE type
537cd10 is described below

commit 537cd10391d953d6f4f56e795667a7241fe3fa4a
Author: Timo Walther <tw...@apache.org>
AuthorDate: Thu May 2 09:17:55 2019 +0200

    [FLINK-12253][table-common] Add a DOUBLE type
---
 .../flink/table/types/logical/DoubleType.java      | 91 ++++++++++++++++++++++
 .../table/types/logical/LogicalTypeVisitor.java    |  2 +
 .../apache/flink/table/types/LogicalTypesTest.java | 14 ++++
 3 files changed, 107 insertions(+)

diff --git a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/DoubleType.java b/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/DoubleType.java
new file mode 100644
index 0000000..90d1429
--- /dev/null
+++ b/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/DoubleType.java
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.types.logical;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Set;
+
+/**
+ * Logical type of an 8-byte double precision floating point number.
+ *
+ * <p>The serialized string representation is {@code DOUBLE}.
+ */
+@PublicEvolving
+public final class DoubleType extends LogicalType {
+
+	private static final String FORMAT = "DOUBLE";
+
+	private static final Set<String> NULL_OUTPUT_CONVERSION = conversionSet(
+		Double.class.getName());
+
+	private static final Set<String> NOT_NULL_INPUT_OUTPUT_CONVERSION = conversionSet(
+		Double.class.getName(),
+		double.class.getName());
+
+	private static final Class<?> DEFAULT_CONVERSION = Double.class;
+
+	public DoubleType(boolean isNullable) {
+		super(isNullable, LogicalTypeRoot.DOUBLE);
+	}
+
+	public DoubleType() {
+		this(true);
+	}
+
+	@Override
+	public LogicalType copy(boolean isNullable) {
+		return new DoubleType(isNullable);
+	}
+
+	@Override
+	public String asSerializableString() {
+		return withNullability(FORMAT);
+	}
+
+	@Override
+	public boolean supportsInputConversion(Class<?> clazz) {
+		return NOT_NULL_INPUT_OUTPUT_CONVERSION.contains(clazz.getName());
+	}
+
+	@Override
+	public boolean supportsOutputConversion(Class<?> clazz) {
+		if (isNullable()) {
+			return NULL_OUTPUT_CONVERSION.contains(clazz.getName());
+		}
+		return NOT_NULL_INPUT_OUTPUT_CONVERSION.contains(clazz.getName());
+	}
+
+	@Override
+	public Class<?> getDefaultConversion() {
+		return DEFAULT_CONVERSION;
+	}
+
+	@Override
+	public List<LogicalType> getChildren() {
+		return Collections.emptyList();
+	}
+
+	@Override
+	public <R> R accept(LogicalTypeVisitor<R> visitor) {
+		return visitor.visit(this);
+	}
+}
diff --git a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalTypeVisitor.java b/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalTypeVisitor.java
index fbfc450..6567ced 100644
--- a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalTypeVisitor.java
+++ b/flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalTypeVisitor.java
@@ -51,5 +51,7 @@ public interface LogicalTypeVisitor<R> {
 
 	R visit(FloatType floatType);
 
+	R visit(DoubleType doubleType);
+
 	R visit(LogicalType other);
 }
diff --git a/flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/LogicalTypesTest.java b/flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/LogicalTypesTest.java
index 979d76b..9ba540a 100644
--- a/flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/LogicalTypesTest.java
+++ b/flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/LogicalTypesTest.java
@@ -23,6 +23,7 @@ import org.apache.flink.table.types.logical.BinaryType;
 import org.apache.flink.table.types.logical.BooleanType;
 import org.apache.flink.table.types.logical.CharType;
 import org.apache.flink.table.types.logical.DecimalType;
+import org.apache.flink.table.types.logical.DoubleType;
 import org.apache.flink.table.types.logical.FloatType;
 import org.apache.flink.table.types.logical.IntType;
 import org.apache.flink.table.types.logical.LogicalType;
@@ -191,6 +192,19 @@ public class LogicalTypesTest {
 		);
 	}
 
+	@Test
+	public void testDoubleType() {
+		testAll(
+			new DoubleType(),
+			"DOUBLE",
+			"DOUBLE",
+			new Class[]{Double.class, double.class},
+			new Class[]{Double.class},
+			new LogicalType[]{},
+			new DoubleType(false)
+		);
+	}
+
 	// --------------------------------------------------------------------------------------------
 
 	private static void testAll(