You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/31 06:52:37 UTC

[GitHub] mistercrunch commented on a change in pull request #5515: convert position to v2 for Superset load_examples

mistercrunch commented on a change in pull request #5515: convert position to v2 for Superset load_examples
URL: https://github.com/apache/incubator-superset/pull/5515#discussion_r206411816
 
 

 ##########
 File path: superset/data/__init__.py
 ##########
 @@ -351,7 +366,7 @@ def load_world_bank_health_n_pop():
                 secondary_metric='sum__SP_POP_TOTL',
                 series="country_name",)),
     ]
-    misc_dash_slices.append(slices[-1].slice_name)
+    # misc_dash_slices.append(slices[-1].slice_name)
 
 Review comment:
   leftover commented line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org