[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3402: Improve some exception handling

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3402:
URL: https://github.com/apache/accumulo/pull/3402#discussion_r1196663217


##########
core/src/main/java/org/apache/accumulo/core/conf/cluster/ClusterConfigParser.java:
##########
@@ -61,14 +61,12 @@ private static void flatten(String parentKey, String key, Object value,
         (parentKey == null || parentKey.equals("")) ? "" : parentKey + addTheDot(parentKey);
     if (value instanceof String) {
       results.put(parent + key, (String) value);
-      return;

Review Comment:
   The method is already very short. These aren't needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org