You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "BradWalker (via GitHub)" <gi...@apache.org> on 2023/06/15 02:12:19 UTC
[GitHub] [netbeans] BradWalker commented on a diff in pull request #6028: Enable modules to depend on CPU architecture, Update OpenJFX and support Aarch64 for Linux and mac OS
BradWalker commented on code in PR #6028:
URL: https://github.com/apache/netbeans/pull/6028#discussion_r1217246898
##########
platform/core.startup/src/org/netbeans/core/startup/ConsistencyVerifier.java:
##########
@@ -91,7 +99,20 @@ public static SortedMap<String,SortedSet<String>> findInconsistencies(
"org.openide.modules.os.MacOSX, " + // NOI18N
"org.openide.modules.os.Linux, " + // NOI18N
"org.openide.modules.os.Solaris, " + // NOI18N
- "org.openide.modules.os.OS2"); // NOI18N
+ "org.openide.modules.os.OS2, " + // NOI18N
+ "org.openide.modules.arch.x86_64, " + // NOI18N
+ "org.openide.modules.arch.amd64, " + // NOI18N
+ "org.openide.modules.arch.x86," + // NOI18N
+ "org.openide.modules.arch.aarch64," + // NOI18N
+ "org.openide.modules.arch.arm," + // NOI18N
+ "org.openide.modules.arch.ppc," + // NOI18N
+ "org.openide.modules.arch.ppc64," + // NOI18N
+ "org.openide.modules.arch.ppc64le," + // NOI18N
+ "org.openide.modules.arch.s390x," + // NOI18N
+ "org.openide.modules.arch.zarch_64," + // NOI18N
+ "org.openide.modules.arch.sparc" + // NOI18N
+ "org.openide.modules.arch.sparcv9" + // NOI18N
+ "");
Review Comment:
Also @matthiasblaesing , this work is likely to affect the platform as it's going to most likely be integrated into JDK 21.
https://bugs.openjdk.org/browse/JDK-8304915
##########
platform/core.startup/src/org/netbeans/core/startup/ConsistencyVerifier.java:
##########
@@ -91,7 +99,21 @@ public static SortedMap<String,SortedSet<String>> findInconsistencies(
"org.openide.modules.os.MacOSX, " + // NOI18N
"org.openide.modules.os.Linux, " + // NOI18N
"org.openide.modules.os.Solaris, " + // NOI18N
- "org.openide.modules.os.OS2"); // NOI18N
+ "org.openide.modules.os.OS2, " + // NOI18N
+ "org.openide.modules.arch.x86_64, " + // NOI18N
+ "org.openide.modules.arch.amd64, " + // NOI18N
+ "org.openide.modules.arch.x86," + // NOI18N
+ "org.openide.modules.arch.aarch64," + // NOI18N
+ "org.openide.modules.arch.arm," + // NOI18N
+ "org.openide.modules.arch.ppc," + // NOI18N
+ "org.openide.modules.arch.ppc64," + // NOI18N
+ "org.openide.modules.arch.ppc64le," + // NOI18N
+ "org.openide.modules.arch.s390x," + // NOI18N
+ "org.openide.modules.arch.zarch_64," + // NOI18N
+ "org.openide.modules.arch.sparc," + // NOI18N
Review Comment:
Hey @matthiasblaesing , I really don't like that we still support SPARC. It's a long time dead platform.
Also, not a fan of including SPARC64 support. As it's been removed from the JDK for a little while.
##########
platform/core.startup/src/org/netbeans/core/startup/ConsistencyVerifier.java:
##########
@@ -91,7 +99,20 @@ public static SortedMap<String,SortedSet<String>> findInconsistencies(
"org.openide.modules.os.MacOSX, " + // NOI18N
"org.openide.modules.os.Linux, " + // NOI18N
"org.openide.modules.os.Solaris, " + // NOI18N
- "org.openide.modules.os.OS2"); // NOI18N
+ "org.openide.modules.os.OS2, " + // NOI18N
+ "org.openide.modules.arch.x86_64, " + // NOI18N
+ "org.openide.modules.arch.amd64, " + // NOI18N
+ "org.openide.modules.arch.x86," + // NOI18N
+ "org.openide.modules.arch.aarch64," + // NOI18N
+ "org.openide.modules.arch.arm," + // NOI18N
+ "org.openide.modules.arch.ppc," + // NOI18N
+ "org.openide.modules.arch.ppc64," + // NOI18N
+ "org.openide.modules.arch.ppc64le," + // NOI18N
+ "org.openide.modules.arch.s390x," + // NOI18N
+ "org.openide.modules.arch.zarch_64," + // NOI18N
+ "org.openide.modules.arch.sparc" + // NOI18N
+ "org.openide.modules.arch.sparcv9" + // NOI18N
+ "");
Review Comment:
Hey @matthiasblaesing , I really don't like how these architectures are included.
For examle,
JEP 381: Remove the Solaris and SPARC Ports (delivered JDK 15)
JEP 449: Deprecate the Windows 32-bit x86 Port for Removal (integrated and slated for delivery in JDK 21)
The ARM work is difficult to figure out if it's still supported. There was a JEP to include it as part of the AARCH64 work originally. But, it doesn't look to be formally deprecated. But, it also doesn't look like there has been much support after JDK 8 either.
But, I really would like to hear your comments as they could frame future work around this stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists