You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/10/28 19:22:27 UTC

[GitHub] [nifi] gresockj opened a new pull request #5494: NIFI-9343: Adding config verification to GCP processors

gresockj opened a new pull request #5494:
URL: https://github.com/apache/nifi/pull/5494


   Thank you for submitting a contribution to Apache NiFi.
   
   Please provide a short description of the PR here:
   
   #### Description of PR
   
   Adds config verification support to:
   - `GCPCredentialsControllerService` - failure can be seen if providing valid but incomplete JSON
   - `ConsumeGCPubSub` - Added steps for parsing the subscriber name from the Subscription, and creating the Subscriber
   - `PublishGCPubSub` - Added step for creating the Publisher
   - `PutBigQueryBatch/PutBigQueryStreaming` - Added a step for creating the BigQuery client service
   - `DeleteGCSObject/PutGCSObject` - Added a step for creating the Storage client service
   - `FetchGCSObject` - Added steps for creating the Storage client service and actually fetching the object (the fetched bytes are displayed in a success message)
   - `ListGCSBucket` - Added steps for creating the Storage client service and actually listing the bucket, displaying the number of listed blobs in the success message.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
   
   - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] gresockj commented on pull request #5494: NIFI-9343: Adding config verification to GCP processors

Posted by GitBox <gi...@apache.org>.
gresockj commented on pull request #5494:
URL: https://github.com/apache/nifi/pull/5494#issuecomment-990909849


   > I made a lot of tests and it's working as I'd expect this to be. A few suggestions:
   > 
   > * PutGCS, DeleteGCS - if the bucket does not exist, no error, could be something to check?
   > * PublishGCPubSub, PublishGCPubSubLite - we don't check if the topic exist, not sure if easy to check
   > * ConsumeGCPubSub, ConsumeGCPubSubLite - we don't check if the subscription exist, not sure if easy to check
   > * PutBigQueryBatch, PutBigQueryStreaming - we don't check if the dataset / table name exist, not sure if easy to check
   > 
   > Not sure if the above can be added and can definitely be follow-up JIRAs. Thoughts? (regardless of the above, I'm a +1 and I can merge, let me know)
   
   Thanks for the feedback, @pvillard31 !  I had considered these cases originally, but could not find a way to exercise these methods without making the actual calls.  However, upon further review I now see an API method named `testIamPermissions` that looks promising.  I'll check this out and add some more verification if possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] asfgit closed pull request #5494: NIFI-9343: Adding config verification to GCP processors

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #5494:
URL: https://github.com/apache/nifi/pull/5494


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] pvillard31 commented on pull request #5494: NIFI-9343: Adding config verification to GCP processors

Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #5494:
URL: https://github.com/apache/nifi/pull/5494#issuecomment-991748313


   Tested the changes, looking great, merging, thanks @gresockj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] gresockj commented on pull request #5494: NIFI-9343: Adding config verification to GCP processors

Posted by GitBox <gi...@apache.org>.
gresockj commented on pull request #5494:
URL: https://github.com/apache/nifi/pull/5494#issuecomment-991260423


   Ok, I've pushed an update using `testIamPermissions` where possible.  This greatly improves the utility of the verification for GCP -- good catch!
   
   I also updated the guava version to 31.0.1-jre instead of 31.0.1-android, which comes from nifi-gcp-services-api.  This conflicted with certain classes, such as `ImmutableList` that were used in nifi-gcp-processors.  So far I have not detected any runtime conflicts from this change, but wanted to point it out here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] gresockj commented on pull request #5494: NIFI-9343: Adding config verification to GCP processors

Posted by GitBox <gi...@apache.org>.
gresockj commented on pull request #5494:
URL: https://github.com/apache/nifi/pull/5494#issuecomment-991260423


   Ok, I've pushed an update using `testIamPermissions` where possible.  This greatly improves the utility of the verification for GCP -- good catch!
   
   I also updated the guava version to 31.0.1-jre instead of 31.0.1-android, which comes from nifi-gcp-services-api.  This conflicted with certain classes, such as `ImmutableList` that were used in nifi-gcp-processors.  So far I have not detected any runtime conflicts from this change, but wanted to point it out here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] pvillard31 commented on pull request #5494: NIFI-9343: Adding config verification to GCP processors

Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #5494:
URL: https://github.com/apache/nifi/pull/5494#issuecomment-990824161


   Reviewing/testing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] asfgit closed pull request #5494: NIFI-9343: Adding config verification to GCP processors

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #5494:
URL: https://github.com/apache/nifi/pull/5494


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nifi] pvillard31 commented on pull request #5494: NIFI-9343: Adding config verification to GCP processors

Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #5494:
URL: https://github.com/apache/nifi/pull/5494#issuecomment-991748313


   Tested the changes, looking great, merging, thanks @gresockj 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org