You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/11/23 21:15:03 UTC
[kudu-CR] Disable checkstyle plugin on Jenkins
Hello Will Berkeley, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5209
to review the following change.
Change subject: Disable checkstyle plugin on Jenkins
......................................................................
Disable checkstyle plugin on Jenkins
Checkstyle with maven 3.0.x does not honor the checkstyle excludes
configuration in the root pom, so it prints huge amounts of warnings
for generated protobuf classes. I haven't been able to find a way around
this, except to either send the warnings to a file, or disable
checkstyle on Jenkins. I chose disabling on Jenkins, since no one is
going to look at 12MiB of bogus warnings in XML form, but developers may
see the warnings when running locally with a less ancient maven version.
Change-Id: If283e741bfe0cc53627d2ccdfe9f7eb7c1558d5c
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/5209/1
--
To view, visit http://gerrit.cloudera.org:8080/5209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If283e741bfe0cc53627d2ccdfe9f7eb7c1558d5c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Disable checkstyle plugin on Jenkins
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Disable checkstyle plugin on Jenkins
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5209/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
Line 359: -Dcheckstyle.skip \
Would be nice to add a comment before this invocation explaining why checkstyle is disabled.
--
To view, visit http://gerrit.cloudera.org:8080/5209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If283e741bfe0cc53627d2ccdfe9f7eb7c1558d5c
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] Disable checkstyle plugin on Jenkins
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has uploaded a new patch set (#2).
Change subject: Disable checkstyle plugin on Jenkins
......................................................................
Disable checkstyle plugin on Jenkins
Checkstyle with maven 3.0.x does not honor the checkstyle excludes
configuration in the root pom, so it prints huge amounts of warnings
for generated protobuf classes. I haven't been able to find a way around
this, except to either send the warnings to a file, or disable
checkstyle on Jenkins. I chose disabling on Jenkins, since no one is
going to look at 12MiB of bogus warnings in XML form, but developers may
see the warnings when running locally with a less ancient maven version.
Change-Id: If283e741bfe0cc53627d2ccdfe9f7eb7c1558d5c
---
M build-support/jenkins/build-and-test.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/5209/2
--
To view, visit http://gerrit.cloudera.org:8080/5209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If283e741bfe0cc53627d2ccdfe9f7eb7c1558d5c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Disable checkstyle plugin on Jenkins
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has abandoned this change.
Change subject: Disable checkstyle plugin on Jenkins
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5209
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: If283e741bfe0cc53627d2ccdfe9f7eb7c1558d5c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>