Re: [PR] Docs: Document nightly snapshots [iceberg]

["kevinjqliu (via GitHub)" <gi...@apache.org>]

kevinjqliu commented on code in PR #16544:
URL: https://github.com/apache/iceberg/pull/16544#discussion_r3449820476


##########
site/mkdocs.yml:
##########
@@ -112,6 +112,7 @@ markdown_extensions:
 
 extra:
   icebergVersion: '1.11.0'
+  snapshotVersion: '1.12.0-SNAPSHOT'

Review Comment:
   does the version number really matter here? 
   might not be a good idea to introduce yet another variable here. we can just reuse `icebergVersion` if possible



##########
site/docs/nightly-snapshots.md:
##########


Review Comment:
   could you include a screenshot of local rendering? maybe in the PR descriptions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org