You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/05/05 23:46:06 UTC
[GitHub] [cordova-plugin-splashscreen] timbru31 commented on a change in
pull request #187: [Android] Fix for back button does not work as expected
on SDK 28
timbru31 commented on a change in pull request #187: [Android] Fix for back button does not work as expected on SDK 28
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/187#discussion_r281043901
##########
File path: src/android/SplashScreen.java
##########
@@ -97,12 +98,14 @@ protected void pluginInitialize() {
}
// Make WebView invisible while loading URL
// CB-11326 Ensure we're calling this on UI thread
- cordova.getActivity().runOnUiThread(new Runnable() {
- @Override
- public void run() {
- getView().setVisibility(View.INVISIBLE);
- }
- });
+ if (Build.VERSION.SDK_INT < 28) {
+ cordova.getActivity().runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ getView().setVisibility(View.INVISIBLE);
+ }
Review comment:
the indentation seems wrong here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org