You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/06/02 22:18:00 UTC
[jira] [Commented] (SOLR-15385) Address rawtypes warnings
[ https://issues.apache.org/jira/browse/SOLR-15385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17355997#comment-17355997 ]
ASF subversion and git services commented on SOLR-15385:
--------------------------------------------------------
Commit c8e06a7298a2745c2b83102169073e2f8e8eceb5 in solr's branch refs/heads/main from Mike Drob
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=c8e06a7 ]
SOLR-15385 Address many rawtypes warnings (#107)
Addressed significant usage of raw types with Class, Map, and SolrRequest; removed over 400 SuppressWarning annotations.
Map construction was replaced with Map.of when immutability was possible, and Utils.makeMap when a mutable map was required.
Discovered a potential bug in the PackageStore tests where not all assertions were being verified - these tests will be fixed separately.
Co-authored-by: David Smiley <ds...@salesforce.com>
> Address rawtypes warnings
> -------------------------
>
> Key: SOLR-15385
> URL: https://issues.apache.org/jira/browse/SOLR-15385
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mike Drob
> Priority: Major
>
> We have a lot of suppressed warnings, some of these are easy to deal with and not hiding bugs, but the more I look at these, the scarier some of them get.
> We have a few really nasty instances of "type laundering" going on, as well as plenty of cases of Map<String,Object> with nested structures hiding inside of that Object. We can clean up big chunks of this
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org